-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plan validator for timestamp with timezone check for prestissimo #23200
Merged
feilong-liu
merged 1 commit into
prestodb:master
from
feilong-liu:timestamp_timezone_validate
Jul 13, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
191 changes: 191 additions & 0 deletions
191
...rc/main/java/com/facebook/presto/sql/planner/sanity/CheckNoTimestampWithTimezoneType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,191 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.sql.planner.sanity; | ||
|
|
||
| import com.facebook.presto.Session; | ||
| import com.facebook.presto.common.type.ArrayType; | ||
| import com.facebook.presto.common.type.MapType; | ||
| import com.facebook.presto.common.type.RowType; | ||
| import com.facebook.presto.common.type.Type; | ||
| import com.facebook.presto.expressions.DefaultRowExpressionTraversalVisitor; | ||
| import com.facebook.presto.metadata.Metadata; | ||
| import com.facebook.presto.spi.WarningCollector; | ||
| import com.facebook.presto.spi.plan.AggregationNode; | ||
| import com.facebook.presto.spi.plan.FilterNode; | ||
| import com.facebook.presto.spi.plan.PlanNode; | ||
| import com.facebook.presto.spi.plan.ProjectNode; | ||
| import com.facebook.presto.spi.plan.ValuesNode; | ||
| import com.facebook.presto.spi.relation.CallExpression; | ||
| import com.facebook.presto.spi.relation.ConstantExpression; | ||
| import com.facebook.presto.spi.relation.InputReferenceExpression; | ||
| import com.facebook.presto.spi.relation.IntermediateFormExpression; | ||
| import com.facebook.presto.spi.relation.RowExpression; | ||
| import com.facebook.presto.spi.relation.SpecialFormExpression; | ||
| import com.facebook.presto.spi.relation.VariableReferenceExpression; | ||
| import com.facebook.presto.sql.parser.SqlParser; | ||
| import com.facebook.presto.sql.planner.SimplePlanVisitor; | ||
| import com.facebook.presto.sql.planner.TypeProvider; | ||
| import com.facebook.presto.sql.planner.plan.WindowNode; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import static com.facebook.presto.common.type.TimestampWithTimeZoneType.TIMESTAMP_WITH_TIME_ZONE; | ||
| import static com.google.common.base.Preconditions.checkState; | ||
|
|
||
| public class CheckNoTimestampWithTimezoneType | ||
| implements PlanChecker.Checker | ||
| { | ||
| private static final String errorMessage = "Timestamp with Timezone type is not supported in Prestissimo"; | ||
|
|
||
| @Override | ||
| public void validate(PlanNode planNode, Session session, Metadata metadata, SqlParser sqlParser, TypeProvider types, WarningCollector warningCollector) | ||
| { | ||
| planNode.accept(new Visitor(), null); | ||
| } | ||
|
|
||
| private static class Visitor | ||
| extends SimplePlanVisitor<Void> | ||
| { | ||
| private final NoTimeStampWithTimeZoneTypeChecker noTimeStampWithTimeZoneTypeChecker; | ||
|
|
||
| public Visitor() | ||
| { | ||
| this.noTimeStampWithTimeZoneTypeChecker = new NoTimeStampWithTimeZoneTypeChecker(); | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitPlan(PlanNode node, Void context) | ||
| { | ||
| checkState(node.getOutputVariables().stream().noneMatch(x -> hasTimestampWithTimezoneType(x.getType())), errorMessage); | ||
| return super.visitPlan(node, context); | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitAggregation(AggregationNode node, Void context) | ||
| { | ||
| visitPlan(node, context); | ||
| node.getAggregations().forEach((variable, aggregation) -> { | ||
| aggregation.getCall().accept(noTimeStampWithTimeZoneTypeChecker, null); | ||
| if (aggregation.getFilter().isPresent()) { | ||
| aggregation.getFilter().get().accept(noTimeStampWithTimeZoneTypeChecker, null); | ||
| } | ||
| }); | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitWindow(WindowNode node, Void context) | ||
| { | ||
| visitPlan(node, context); | ||
| node.getWindowFunctions().forEach((variable, function) -> { | ||
| function.getFunctionCall().accept(noTimeStampWithTimeZoneTypeChecker, null); | ||
| }); | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitProject(ProjectNode node, Void context) | ||
| { | ||
| visitPlan(node, context); | ||
| node.getAssignments().getMap().forEach((variable, expression) -> { | ||
| expression.accept(noTimeStampWithTimeZoneTypeChecker, null); | ||
| }); | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitValues(ValuesNode node, Void context) | ||
| { | ||
| visitPlan(node, context); | ||
| for (List<RowExpression> row : node.getRows()) { | ||
| row.forEach(x -> x.accept(noTimeStampWithTimeZoneTypeChecker, null)); | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitFilter(FilterNode node, Void context) | ||
| { | ||
| visitPlan(node, context); | ||
| node.getPredicate().accept(noTimeStampWithTimeZoneTypeChecker, null); | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| private static class NoTimeStampWithTimeZoneTypeChecker | ||
| extends DefaultRowExpressionTraversalVisitor<Void> | ||
| { | ||
| @Override | ||
| public Void visitConstant(ConstantExpression literal, Void context) | ||
| { | ||
| checkState(!hasTimestampWithTimezoneType(literal.getType()), errorMessage); | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitVariableReference(VariableReferenceExpression reference, Void context) | ||
| { | ||
| checkState(!hasTimestampWithTimezoneType(reference.getType()), errorMessage); | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitInputReference(InputReferenceExpression input, Void context) | ||
| { | ||
| checkState(!hasTimestampWithTimezoneType(input.getType()), errorMessage); | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitCall(CallExpression call, Void context) | ||
| { | ||
| checkState(!hasTimestampWithTimezoneType(call.getType()), errorMessage); | ||
| return super.visitCall(call, context); | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitSpecialForm(SpecialFormExpression specialForm, Void context) | ||
| { | ||
| checkState(!hasTimestampWithTimezoneType(specialForm.getType()), errorMessage); | ||
| return super.visitSpecialForm(specialForm, context); | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitIntermediateFormExpression(IntermediateFormExpression expression, Void context) | ||
| { | ||
| checkState(!hasTimestampWithTimezoneType(expression.getType()), errorMessage); | ||
| return super.visitIntermediateFormExpression(expression, context); | ||
| } | ||
| } | ||
|
|
||
| private static boolean hasTimestampWithTimezoneType(Type type) | ||
| { | ||
| if (type.equals(TIMESTAMP_WITH_TIME_ZONE)) { | ||
| return true; | ||
| } | ||
| if (type instanceof ArrayType) { | ||
| return hasTimestampWithTimezoneType(((ArrayType) type).getElementType()); | ||
| } | ||
| else if (type instanceof MapType) { | ||
| return hasTimestampWithTimezoneType(((MapType) type).getKeyType()) || hasTimestampWithTimezoneType(((MapType) type).getValueType()); | ||
| } | ||
| else if (type instanceof RowType) { | ||
| return ((RowType) type).getTypeParameters().stream().anyMatch(CheckNoTimestampWithTimezoneType::hasTimestampWithTimezoneType); | ||
| } | ||
| return false; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
...est/java/com/facebook/presto/sql/planner/sanity/TestCheckNoTimestampWithTimezoneType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.sql.planner.sanity; | ||
|
|
||
| import com.facebook.presto.Session; | ||
| import com.facebook.presto.metadata.Metadata; | ||
| import com.facebook.presto.spi.WarningCollector; | ||
| import com.facebook.presto.spi.plan.PlanNode; | ||
| import com.facebook.presto.spi.plan.PlanNodeIdAllocator; | ||
| import com.facebook.presto.spi.relation.VariableReferenceExpression; | ||
| import com.facebook.presto.sql.parser.SqlParser; | ||
| import com.facebook.presto.sql.planner.TypeProvider; | ||
| import com.facebook.presto.sql.planner.assertions.BasePlanTest; | ||
| import com.facebook.presto.sql.planner.iterative.rule.test.PlanBuilder; | ||
| import org.testng.annotations.AfterClass; | ||
| import org.testng.annotations.BeforeClass; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.function.Function; | ||
|
|
||
| import static com.facebook.presto.SessionTestUtils.TEST_SESSION; | ||
| import static com.facebook.presto.common.type.BooleanType.BOOLEAN; | ||
| import static com.facebook.presto.common.type.TimestampWithTimeZoneType.TIMESTAMP_WITH_TIME_ZONE; | ||
| import static com.facebook.presto.common.type.VarcharType.VARCHAR; | ||
| import static com.facebook.presto.sql.planner.iterative.rule.test.PlanBuilder.assignment; | ||
| import static com.facebook.presto.testing.TestingSession.testSessionBuilder; | ||
|
|
||
| public class TestCheckNoTimestampWithTimezoneType | ||
| extends BasePlanTest | ||
| { | ||
| private Session testSession; | ||
| private Metadata metadata; | ||
| private SqlParser sqlParser; | ||
| private PlanNodeIdAllocator idAllocator = new PlanNodeIdAllocator(); | ||
|
|
||
| @BeforeClass | ||
| public void setup() | ||
| { | ||
| Session.SessionBuilder sessionBuilder = testSessionBuilder() | ||
| .setCatalog("local") | ||
| .setSchema("tiny"); | ||
| testSession = sessionBuilder.build(); | ||
| metadata = getQueryRunner().getMetadata(); | ||
| sqlParser = getQueryRunner().getSqlParser(); | ||
| } | ||
|
|
||
| @AfterClass(alwaysRun = true) | ||
| public void tearDown() | ||
| { | ||
| testSession = null; | ||
| metadata = null; | ||
| sqlParser = null; | ||
| idAllocator = null; | ||
| } | ||
|
|
||
| @Test(expectedExceptions = IllegalStateException.class, expectedExceptionsMessageRegExp = "Timestamp with Timezone type is not supported in Prestissimo") | ||
| public void testValidateProjectFail() | ||
| { | ||
| validatePlan( | ||
| p -> { | ||
| VariableReferenceExpression col = p.variable("col", VARCHAR); | ||
| VariableReferenceExpression col2 = p.variable("col2", TIMESTAMP_WITH_TIME_ZONE); | ||
| return p.project( | ||
| assignment(col2, p.rowExpression("cast(col as timestamp with time zone)")), | ||
| p.values(col)); | ||
| }); | ||
| } | ||
|
|
||
| @Test(expectedExceptions = IllegalStateException.class, expectedExceptionsMessageRegExp = "Timestamp with Timezone type is not supported in Prestissimo") | ||
| public void testValidateProjectAssignmentFail() | ||
| { | ||
| validatePlan( | ||
| p -> { | ||
| VariableReferenceExpression col = p.variable("col", VARCHAR); | ||
| VariableReferenceExpression col1 = p.variable("col1", VARCHAR); | ||
| VariableReferenceExpression col2 = p.variable("col2", BOOLEAN); | ||
| return p.project( | ||
| assignment(col2, p.rowExpression("cast(col as timestamp with time zone) > cast(col1 as timestamp with time zone)")), | ||
| p.values(col, col1)); | ||
| }); | ||
| } | ||
|
|
||
| @Test(expectedExceptions = IllegalStateException.class, expectedExceptionsMessageRegExp = "Timestamp with Timezone type is not supported in Prestissimo") | ||
| public void testValidateValueFail() | ||
| { | ||
| validatePlan( | ||
| p -> { | ||
| VariableReferenceExpression col = p.variable("col", TIMESTAMP_WITH_TIME_ZONE); | ||
| VariableReferenceExpression col2 = p.variable("col2", VARCHAR); | ||
| return p.project( | ||
| assignment(col2, p.rowExpression("cast(col as varchar)")), | ||
| p.values(col)); | ||
| }); | ||
| } | ||
|
|
||
| private void validatePlan(Function<PlanBuilder, PlanNode> planProvider) | ||
| { | ||
| PlanBuilder builder = new PlanBuilder(TEST_SESSION, idAllocator, metadata); | ||
| PlanNode planNode = planProvider.apply(builder); | ||
| TypeProvider types = builder.getTypes(); | ||
| getQueryRunner().inTransaction(testSession, session -> { | ||
| session.getCatalog().ifPresent(catalog -> metadata.getCatalogHandle(session, catalog)); | ||
| new CheckNoTimestampWithTimezoneType().validate(planNode, session, metadata, sqlParser, types, WarningCollector.NOOP); | ||
| return null; | ||
| }); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gggrace14 @kgpai @kagamiori For testing the timestamp comparison features, we will need to turn this on in deployment configs.