Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix round for float value when input out of long range #23765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix round for float value when input out of long range #23765

wants to merge 1 commit into from
+14 −1

Conversation

hantangwangd
Copy link
Member

@hantangwangd hantangwangd commented Oct 3, 2024 •
edited by elharo
Loading

Description

Fixes #23763

Motivation and Context

Fix issue: #23763

Impact

N/A

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@hantangwangd hantangwangd mentioned this pull request Oct 3, 2024
Open
@hantangwangd hantangwangd marked this pull request as ready for review October 3, 2024 02:45
@hantangwangd hantangwangd requested a review from a team as a code owner October 3, 2024 02:45
elharo
elharo reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

presto-main/src/test/java/com/facebook/presto/operator/scalar/TestMathFunctions.java Outdated
@@ -814,6 +814,9 @@ public void testRound()
assertFunction("round(REAL '90000000.0', 1000)", REAL, 90000000.0f);
assertFunction("round(REAL '300000000.0', 100)", REAL, 300000000.0f);
assertFunction("round(REAL '-300000000.0', 100)", REAL, -300000000.0f);
assertFunction("round(REAL '1.0E19', 1)", REAL, 1.0E19f);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably go in a new test method with a comment linking to the bug so they can pass or fail independently

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, fixed! Please take a look when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Round function returns incorrect results for large floats
2 participants
@hantangwangd @elharo