Skip to content

Fix round for float value when input out of long range #23765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix round for float value when input out of long range #23765

merged 1 commit into from
Oct 10, 2024

Conversation

hantangwangd
Copy link
Member

@hantangwangd hantangwangd commented Oct 3, 2024 •
edited by elharo
Loading

Description

Fixes #23763

Motivation and Context

Fix issue: #23763

Impact

N/A

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@hantangwangd hantangwangd mentioned this pull request Oct 3, 2024
Closed
@hantangwangd hantangwangd marked this pull request as ready for review October 3, 2024 02:45
@hantangwangd hantangwangd requested a review from a team as a code owner October 3, 2024 02:45
elharo
elharo reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@hantangwangd hantangwangd requested a review from tdcmeehan October 7, 2024 14:58
@tdcmeehan tdcmeehan self-assigned this Oct 10, 2024
@tdcmeehan tdcmeehan merged commit cbd1a11 into prestodb:master Oct 10, 2024
56 checks passed
@hantangwangd hantangwangd deleted the fix_round_for_float branch October 10, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@tdcmeehan tdcmeehan tdcmeehan approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees

@tdcmeehan tdcmeehan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Round function returns incorrect results for large floats
3 participants
@hantangwangd @elharo @tdcmeehan