Use Java built-in functions to create failure function #24792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When sidecar is enabled, the coordinator is unable to create a failure function. Use Java functions to create a failure function.
Motivation and Context
When the sidecar is used for query analysis, the default namespace is switched to reflect the different set of functions used in Velox. While eventually we wish to use Velox for both expression evaluation and also as a registry of functions, the former is taking a long time due to refactoring in Velox. In the meantime, we need function evaluation over C++ namespaces to work properly, which means we need to use the Java functions for now. This is a stopgap solution until function evaluation in Velox works end to end. (copied from #25135)
Eg:
java.lang.AssertionError: Execution of 'actual' query failed: SELECT IF(true, 0/0, 1)
Another example would be whenever window queries encounter invalid frames, we create a failure function, which is failing too.
Impact
No impact
Test Plan
Test cases included
Contributor checklist
== RELEASE NOTES ==