Skip to content

Conversation

@hantangwangd
Copy link
Member

@hantangwangd hantangwangd commented May 18, 2025

Description

This PR add the catalog name to the name of Iceberg table that loaded from Hive catalog. Currently in Presto, Iceberg tables loaded from Native catalog (Hadoop, Nessie, Rest) have the table name of format <catalog>.<schema>.<table>, however, Iceberg tables loaded from Hive catalog have the table name of format <schema>.<table>. This may lead in some inconsistencies across different catalogs. For example, the test case in PR #24904 relies on the name of Iceberg table loaded from different catalogs.

Moreover, Iceberg lib itself has a consistent behavior across all catalogs, that is return the full table name including catalog name. See here.

Motivation and Context

Ensure that the names of tables that loaded from different catalogs have consistent formatting

Impact

The names of Iceberg tables loaded from Hive catalog always include catalog names.

Test Plan

  • Newly added test case in TestIcebergDistributedHive to verify that the table name loaded from Hive catalog contains catalog name

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@hantangwangd hantangwangd force-pushed the prefix_catalog_name_for_hive_catalog branch from ec728ca to 8aae81b Compare May 19, 2025 00:34
@hantangwangd hantangwangd force-pushed the prefix_catalog_name_for_hive_catalog branch from 8aae81b to c4b234b Compare May 22, 2025 01:03
@hantangwangd hantangwangd marked this pull request as ready for review May 22, 2025 03:58
@hantangwangd hantangwangd requested review from a team and ZacBlanco as code owners May 22, 2025 03:58
@hantangwangd hantangwangd merged commit c5839d9 into prestodb:master Jun 5, 2025
104 checks passed
@hantangwangd hantangwangd deleted the prefix_catalog_name_for_hive_catalog branch June 5, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants