Skip to content

Conversation

@tdcmeehan
Copy link
Contributor

Description

This will alert on new vulnerabilities that are introduced as part of a PR. For an example output that adds a famous Log4j vulnerability, see here: https://github.com/tdcmeehan/presto/actions/runs/17852872940/job/50765167735?pr=10

Example PR that shows the comment that is generated: tdcmeehan#10 (comment)

This will not initially be mandatory until its quality is assessed.

Motivation and Context

Prevent new CVEs from being introduced.

Impact

Advisory for now

Test Plan

Tested in fork (see above)

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@tdcmeehan tdcmeehan requested review from a team, czentgr and unidevel as code owners September 19, 2025 12:09
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Sep 19, 2025
@prestodb-ci prestodb-ci requested review from a team and nishithakbhaskaran and removed request for a team September 19, 2025 12:09
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 19, 2025

Reviewer's Guide

Introduce a GitHub Actions workflow that runs on pull requests to automatically detect and report new dependency vulnerabilities by leveraging the dependency-review-action.

File-Level Changes

Change Details Files
Add GitHub Actions workflow for dependency review
  • Define pull_request trigger and set contents/pull-requests permissions
  • Include checkout step using actions/checkout@v4
  • Add dependency-review-action@v4 with fail-on-severity and scope options
  • Enable PR comment summary on failure and display OpenSSF Scorecard
.github/workflows/dependency-review.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nishithakbhaskaran
Copy link
Contributor

Thanks for the PR @tdcmeehan . I have a couple of questions:

1)Does this job only get triggered when a dependency version is changed in a pom.xml file within a PR?
2)Does the run provide the corresponding CVE ID(s) as part of the output table?

@tdcmeehan
Copy link
Contributor Author

@nishithakbhaskaran this action will only check new dependencies brought in by the PR. It will list out Github advisories, which link to the underlying CVE (see the comment here: tdcmeehan#10 (comment))

Copy link
Contributor

@nishithakbhaskaran nishithakbhaskaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @tdcmeehan

Copy link
Member

@imjalpreet imjalpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@imjalpreet imjalpreet linked an issue Sep 19, 2025 that may be closed by this pull request
Copy link
Member

@agrawalreetika agrawalreetika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tdcmeehan.

@tdcmeehan
Copy link
Contributor Author

Please note this handles direct dependencies. I'm still working on something more comprehensive for transitive dependencies.

@tdcmeehan tdcmeehan merged commit 6fe5a5d into master Sep 19, 2025
112 of 115 checks passed
@tdcmeehan tdcmeehan deleted the tdcmeehan-dep-review branch September 19, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI Check for CVEs in Newly Added Maven Dependencies

7 participants