-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add GitHub Actions workflow for dependency review #26093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIntroduce a GitHub Actions workflow that runs on pull requests to automatically detect and report new dependency vulnerabilities by leveraging the dependency-review-action. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks for the PR @tdcmeehan . I have a couple of questions: 1)Does this job only get triggered when a dependency version is changed in a pom.xml file within a PR? |
|
@nishithakbhaskaran this action will only check new dependencies brought in by the PR. It will list out Github advisories, which link to the underlying CVE (see the comment here: tdcmeehan#10 (comment)) |
nishithakbhaskaran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thanks @tdcmeehan
imjalpreet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
agrawalreetika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hantangwangd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tdcmeehan.
|
Please note this handles direct dependencies. I'm still working on something more comprehensive for transitive dependencies. |
Description
This will alert on new vulnerabilities that are introduced as part of a PR. For an example output that adds a famous Log4j vulnerability, see here: https://github.com/tdcmeehan/presto/actions/runs/17852872940/job/50765167735?pr=10
Example PR that shows the comment that is generated: tdcmeehan#10 (comment)
This will not initially be mandatory until its quality is assessed.
Motivation and Context
Prevent new CVEs from being introduced.
Impact
Advisory for now
Test Plan
Tested in fork (see above)
Contributor checklist
Release Notes