Skip to content

Conversation

@Sullivan-Patrick
Copy link
Contributor

Summary: This broke a bunch of tests.

Reviewed By: macvincent

Differential Revision: D88879226

…ource"

Summary: This broke a bunch of tests.

Reviewed By: macvincent

Differential Revision: D88879226
@Sullivan-Patrick Sullivan-Patrick requested review from a team as code owners December 10, 2025 20:25
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reverts parts of a previous change by simplifying several catch blocks: it removes unused exception variable bindings while preserving the existing error-handling behavior across tests, task handling, server operations, HTTP responses, and exchange/shuffle operators.

File-Level Changes

Change Details Files
Remove unused exception variable names from catch blocks while preserving existing error-handling behavior.
  • In test code, catch VeloxUserError by type only and fall back to parsing string values without inspecting the exception.
  • In task creation/update logic, catch VeloxException and VeloxUserError by type only, still rethrowing or wrapping as before.
  • In server operations and HTTP response helpers, catch std::exception by type without using the exception instance, keeping the same failure paths and messages.
  • In broadcast and shuffle exchange/write components, catch VeloxException by type and rethrow, leaving downstream error conversion to existing handlers.
presto-native-execution/presto_cpp/main/tests/PrestoToVeloxQueryConfigTest.cpp
presto-native-execution/presto_cpp/main/TaskResource.cpp
presto-native-execution/presto_cpp/main/PrestoServerOperations.cpp
presto-native-execution/presto_cpp/main/http/HttpServer.cpp
presto-native-execution/presto_cpp/main/operators/BroadcastExchangeSource.cpp
presto-native-execution/presto_cpp/main/operators/ShuffleExchangeSource.cpp
presto-native-execution/presto_cpp/main/operators/ShuffleWrite.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tdcmeehan
Copy link
Contributor

"[Diff Train][prestodb/presto] Apply fixup patch to fbsource" doesn't seem to be a commit in this project. Can you help clarify what is being backed out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants