Upgrades for Presto Java 17 support #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be compatible with recent upgrades to airlift and presto for Java 17, Tempto needs some upgrades in order to run against Presto JVMs which have newer dependencies. Guice needs to be upgraded to 7.0 which brings in utilization of the jakarta namespaced injection and annotation dependencies. Additionally, I neeeded to upgrade jsch and mina_sshd dependencies in order to get the existing tests passing. This required some refactoring in test classes
ZacBlanco
force-pushed
the
upstream-jakarta
branch
from
51918ed to
03e7df3
Compare
ZacBlanco
commented
Apr 23, 2025
Comment on lines
+31
to
+32
| jakarta_inject : '2.0.1', | ||
| jakarta_annotation: '2.1.1', |
There was a problem hiding this comment.
These two were added
| reflections : "org.reflections:reflections:${versions.reflections}", | ||
| bytebuddy : "net.bytebuddy:byte-buddy:${versions.bytebuddy}", | ||
| jsch : "com.jcraft:jsch:${versions.jsch}", | ||
| jsch : "com.github.mwiede:jsch:${versions.jsch}", |
There was a problem hiding this comment.
The old jsch was left unmaintained. This fork is maintained and has recent updates
ZacBlanco
commented
Apr 23, 2025
Comment on lines
+56
to
+57
| jsch : '0.2.25', | ||
| mina_sshd : '2.15.0', |
| jakarta_annotation: '2.1.1', | ||
| assertj : '2.0.0', | ||
| guava : '21.0', | ||
| guice : '7.0.0', |
aaneja
approved these changes
Apr 28, 2025
| boolean authenticate(String username, String password, ServerSession session) | ||
| { | ||
| return USER.equals(username) && PASSWORD.equals(password); | ||
| return USER == username && PASSWORD == password; |
There was a problem hiding this comment.
Should use .equals to compare content ?
There was a problem hiding this comment.
I think in groovy it is different than Java. IntelliJ suggested the change. I can revert it though
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be compatible with recent upgrades to airlift and presto for Java 17, Tempto needs some upgrades in order to run against Presto JVMs which have newer dependencies.
Guice needs to be upgraded to 7.0 which brings in utilization of the jakarta namespaced injection and annotation dependencies. Additionally, I neeeded to upgrade jsch and mina_sshd dependencies in order to get the existing tests passing. This required some refactoring in test classes. The project still builds and runs on JDK 8