-
Notifications
You must be signed in to change notification settings - Fork 41
Added test gibberish text across multiple files #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,8 @@ Optimize your code review process with Presubmit's AI Code Reviewer that catches | |
|
|
||
| <br/> | ||
|
|
||
| kaslhdoiasdahosadoisadsioiaojds | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove the random gibberish text |
||
|
|
||
|
Comment on lines
+27
to
+28
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This appears to be random gibberish text that doesn't provide any meaningful content to the README. It should be removed as it disrupts the document's readability and professionalism.
Comment on lines
+27
to
+28
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This appears to be random gibberish text that doesn't belong in the documentation. It disrupts the flow of the README and provides no value to users. This should be removed as it affects the professionalism of the documentation.
Comment on lines
+27
to
+28
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The added gibberish text in the README.md file does not provide any meaningful information and should be removed to maintain professionalism and clarity in documentation.
Comment on lines
+27
to
+28
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This appears to be random gibberish text that doesn't belong in the documentation. It disrupts the flow of the README and should be removed to maintain documentation clarity. |
||
| > 🤝 **Note**: Presubmit is designed to complement human reviewers, not replace them. It helps catch security issues and bugs early on while also providing context about the overall change, making the human review process more efficient. | ||
|
|
||
| <br/> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,10 +17,14 @@ export type File = { | |
| export type Hunk = { | ||
| startLine: number; | ||
| endLine: number; | ||
|
|
||
| diff: string; | ||
|
|
||
| commentThreads?: ReviewCommentThread[]; | ||
| }; | ||
|
|
||
| asd; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Invalid standalone string
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @presubmit good catch. Thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove the invalid statement
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an invalid JavaScript/TypeScript statement that will cause a syntax error. It appears to be a standalone identifier without any assignment or operation, followed by a semicolon.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an invalid standalone statement that will cause a syntax error. JavaScript/TypeScript statements need to be part of a valid expression or declaration, and this lone identifier followed by a semicolon will prevent compilation.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The line
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The insertion of 'asd;' looks like accidental placeholder text. This could break TypeScript compilation if left in. Please remove it.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an invalid standalone statement that will cause a syntax error. JavaScript/TypeScript statements need to be part of a valid expression or declaration. |
||
|
|
||
|
Comment on lines
+26
to
+27
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The line |
||
| export type FileDiff = File & { | ||
| hunks: Hunk[]; | ||
| }; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,5 +21,5 @@ async function main(): Promise<void> { | |
| ); | ||
| } | ||
| } | ||
|
|
||
| dasadsdasdas; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Invalid standalone string
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @presubmit are you sure? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bstanga Yes, I am sure. The line If this was meant to be test code, it should be removed. If you intended to do something with this string, you'll need to use it in a meaningful way, such as:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove the random text
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an invalid statement with random characters that will cause a syntax error. It appears to be a standalone string or identifier without any assignment or operation.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an invalid statement with random characters that will cause a syntax error. It appears right before the main function call and serves no purpose in the code.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The line
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The standalone expression
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The line 'dasadsdasdas;' appears to be extraneous placeholder text and may cause unexpected behavior or errors. Consider removing this statement.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an invalid standalone statement with gibberish text that will cause a syntax error. It appears right before the main function call and serves no purpose in the code. |
||
| main(); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random string
kaslhdoiasdahosadoisadsioiaojdsappears to be unintentional test text that should be removed as it adds no value to the documentation.