Bit-perfect Silver Version differences implemented#131
Open
MDTravisYT wants to merge 17 commits intopret:masterfrom
Open
Bit-perfect Silver Version differences implemented#131MDTravisYT wants to merge 17 commits intopret:masterfrom
MDTravisYT wants to merge 17 commits intopret:masterfrom
Conversation
A number was skipped, causing all IDs past $28 to be misaligned in the comments.
Co-authored-by: Narishma-gb <194818981+Narishma-gb@users.noreply.github.com>
Also changes TOWN_0D to NIGHTTIME. Documented Function9543, Function9536, Function9527
Documented 2 bugs, and 3 functions.
It would make more sense to make duplicate sprite IDs reference the latest definition of it instead of the earliest. Let's say I included the sprite, but commented it out. Now the label it pointed to falls into the next sprite over, thus making it the same as the next sprite over. This change also makes much more sense with certain maps now. Rockets are defined properly in Team Rocket areas, Red's Mom is now defined in her house, and the League buildings are filled with CoolTrainers.
Member
|
Nice work! @MDTravisYT To fix the header you might need to edit the "Global check value" in home/init.asm. Be sure to support a "-correctheader" build as well. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
MDTravisYT
changed the title
Contributor
Author
|
I'll let someone else handle the Makefile side of things. If you provide a debug Silver ROM as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the ROM is compiled with the
SILVERflag defined (code actually checks if notGOLD, so it really can be anything), it now produces a near bit-perfect output of Silver Version, as long as a silver-debug ROM is provided. I say near-bit perfect as it only differs in the header, which I'm not sure how to change.I'm also not sure how to adjust the Makefile so both versions can compile independently like other pret projects. That part's out of my range of knowledge.