Skip to content

On failed offline checkins, transmit which events and list IDs were active (Z#23181592) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

On failed offline checkins, transmit which events and list IDs were active (Z#23181592) #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea6c51
On failed offline checkins, transmit which events and list IDs were s…
luelista Feb 7, 2025
07e692c
pass only checkinlist-IDs
luelista Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libpretixsync/src/main/java/eu/pretix/libpretixsync/check/AsyncCheckProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class AsyncCheckProvider(private val config: ConfigStore, private val dataStore:
this.sentry = sentry
}

private fun storeFailedCheckin(eventSlug: String, listId: Long, error_reason: String, raw_barcode: String, type: TicketCheckProvider.CheckInType, position: Long? = null, item: Long? = null, variation: Long? = null, subevent: Long? = null, nonce: String?) {
private fun storeFailedCheckin(eventSlug: String, listId: Long, error_reason: String, raw_barcode: String, type: TicketCheckProvider.CheckInType, position: Long? = null, item: Long? = null, variation: Long? = null, subevent: Long? = null, nonce: String?, candidateCheckinLists: Collection<Long>? = null) {
/*
:<json boolean error_reason: One of ``canceled``, ``invalid``, ``unpaid``, ``product``, ``rules``, ``revoked``,
``incomplete``, ``already_redeemed``, ``blocked``, ``invalid_time``, or ``error``. Required.
Expand Down Expand Up @@ -71,6 +71,7 @@ class AsyncCheckProvider(private val config: ConfigStore, private val dataStore:
if (item != null && item > 0) jdoc.put("item", item)
if (variation != null && variation > 0) jdoc.put("variation", variation)
if (subevent != null && subevent > 0) jdoc.put("subevent", subevent)
if (candidateCheckinLists != null) jdoc.put("candidate_checkin_lists", candidateCheckinLists)

val qo = QueuedCall()
val api = PretixApi.fromConfig(config) // todo: uses wrong http client
Expand Down Expand Up @@ -278,7 +279,7 @@ class AsyncCheckProvider(private val config: ConfigStore, private val dataStore:
}
if (decoded == null || event == null) {
val firstentry = eventsAndCheckinLists.entries.first()
storeFailedCheckin(firstentry.key, firstentry.value, "invalid", ticketid, type, nonce = nonce)
storeFailedCheckin(firstentry.key, firstentry.value, "invalid", ticketid, type, nonce = nonce, candidateCheckinLists=eventsAndCheckinLists.values)
return TicketCheckProvider.CheckResult(TicketCheckProvider.CheckResult.Type.INVALID, offline = true)
}
val listId = eventsAndCheckinLists[event.slug] ?: return TicketCheckProvider.CheckResult(TicketCheckProvider.CheckResult.Type.ERROR, "Check-in list not set for event", offline = true)
Expand Down