This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Implement DB Event Offers #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luelista
reviewed
Sep 17, 2025
|
|
||
|
|
||
| class SettingsForm(SettingsForm): | ||
| class VARSettingsForm(SettingsForm): |
Member
There was a problem hiding this comment.
Suggested change
| class VARSettingsForm(SettingsForm): | |
| class ECouponSettingsForm(SettingsForm): |
| } | ||
|
|
||
|
|
||
| def is_dbvar_event(event: Event): |
Member
There was a problem hiding this comment.
Suggested change
| def is_dbvar_event(event: Event): | |
| def is_legacy_ecoupon_event(event: Event): |
| return super().save(commit=commit) | ||
|
|
||
|
|
||
| class VATSettingsForm(SettingsForm): |
Member
There was a problem hiding this comment.
Suggested change
| class VATSettingsForm(SettingsForm): | |
| class DBEventOffersSettingsForm(SettingsForm): |
or sth like that
| form_class = SettingsForm | ||
| template_name = "pretix_dbvat/index.html" | ||
| form_class = VARSettingsForm | ||
| template_name = "pretix_dbvat/var/index.html" |
Member
There was a problem hiding this comment.
afaict you accidentally deleted those files instead of moving them
Member
There was a problem hiding this comment.
Suggested change
| template_name = "pretix_dbvat/var/index.html" | |
| template_name = "pretix_dbvat/ecoupon/index.html" |
Member
Author
There was a problem hiding this comment.
Uff - apparently my gitignore just exempted the folder... No wonder it "works on my machine" ;-)
| context_object_name = "coupons" | ||
| form_class = SettingsForm | ||
| template_name = "pretix_dbvat/index.html" | ||
| form_class = VARSettingsForm |
Member
There was a problem hiding this comment.
Suggested change
| form_class = VARSettingsForm | |
| form_class = ECouponSettingsForm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translations pending our approval of the english verbiage