Change BIC check to lookup (Z#23149160) #36
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser8phin
changed the title
Author
|
I haven't yet been able to rule out, that we might have multiple hits on the bic table 😱 but then we'd only use the best match now, as in the one with the most digits from iban |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the payment BIC FormField and looking up the BIC corresponding to the IBAN instead, since it is no longer mandatory to provide the BIC
(german source: https://www.verbraucherzentrale.de/wissen/geld-versicherungen/sparen-und-anlegen/sepa-europaweite-regeln-im-zahlungsverkehr-11512)
I would have preferred to leave the field and make it optional, but there seems to be no indicator on those FormFields, even when setting
required=False, but that's why for now the FormField declaration has only been commented out