App preferences migration #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y for V1 to V2 settings migrations
- Changed from "key" to "api_token" to match API specification - /device/roll returns same response structure as /initialize - Field name verified in libpretixsync SetupManager implementation
- Removed migration logic from Navigation component - Migration now runs automatically when SetupScreen loads - Reuses existing SetupUiState (Loading/Success/Error) instead of custom dialogs - Deleted MigrationProgressDialog - uses existing CircularProgressIndicator - User experience: migration is functionally equivalent to device login - No new UI elements - cleaner, simpler flow Changes: - SetupViewModel: added checkAndExecuteMigration() function - SetupScreen: added LaunchedEffect to trigger migration on load - Navigation.kt: removed all migration-specific code and dialogs - SetupModule.kt: injected MigrationCoordinator dependency - Deleted MigrationProgressDialog.kt
…etup screen inputs should match the rest of the app, add some missing translation keys
…missing stats for multiple events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, several changes are made to the preferences system & login procedure:
Configuration
With this change, the mechanism of storing and reading settings is common to all KMP platforms.
It also allows us to move to Flow-based state in Views and ViewModels (which currently rely on imperative "reload" logic).
Configuration migration has been introduced to carry out migration of settings from an existing installation (e.g. pretixSCAN Desktop v1).
To facilitate troubleshooting of the migration process, structured file logging has been added. Logs are written in the user logs folder in a platform-specific location.
The Settings screen now has a Diagnostics section with a button to easily open the data or logs folder on each platform
Login
When pretixSCAN Desktop 2 is started, it will show the policy screen as usual. When users confirm and are taken to the login screen, the app will initiate the migration procedure (if possible) and automatically sign the user-in.
Workflow
Troubleshooting