test: add ignore-unknown tests #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `ignore-unknown` tests from prettier. Combining `--write` and `--list-different` is not allowed in prettier-cli, so one test was removed which asserted this was possible. Some snapshots were updated because the error message differs.
|
If you could mention the name of the test that wasn't ported over it would be useful, in this case I think it was the "ignore-unknown write" one. I think we should probably keep the test but remove the As I'm understanding it the I think it's probably good to be a little stricter here compared to v3 🤔 I'll make the changes on my end for quick iteration's sake. Thanks 👍 |
|
i think we're doing the right thing and v3 was too lenient (in that you shouldn't be able to combine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
ignore-unknowntests from prettier.Combining
--writeand--list-differentis not allowed in prettier-cli, so one test was removed which asserted this was possible.Some snapshots were updated because the error message differs.