Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: restore previously ignored fixtures #29

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jan 30, 2025

Our gitignore was ignoring all node_modules, including those in fixture data. This was leading to the tests failing as their snapshots would mismatch.

We only actually need to ignore the root /node_modules since we're not n a monorepo (for now at least).

Since these now pass, this also enables a new CI workflow which runs tests.

Our `gitignore` was ignoring all `node_modules`, including those in
fixture data. This was leading to the tests failing as their snapshots
would mismatch.

We only actually need to ignore the root `/node_modules` since we're not
n a monorepo (for now at least).

Since these now pass, this also enables a new CI workflow which runs
tests.
@fabiospampinato fabiospampinato merged commit caa42be into prettier:main Feb 2, 2025
@fabiospampinato
Copy link
Collaborator

Thank you ❤️

@43081j 43081j deleted the fixing-them-tests branch February 2, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants