-
-
Notifications
You must be signed in to change notification settings - Fork 70
chore: bump prettier-eslint v17.0.0-alpha.1 #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b39fe92 The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded@JounQin has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 41 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe changes update several dependencies in the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Bumps several dev dependencies and updates the CLI test expectation to match new formatting behavior.
- Upgrade
@prettier/eslintto v17.0.0-alpha.1,globto v10.4.5,@changesets/clito v2.29.4, andtypescript-eslintto v8.32.1. - Adjust the expected output in the CLI spec to reflect
window.bazinstead ofglobalThis.baz.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/tests/cli.spec.js | Updated expected stdout to use window.baz in formatted code |
| package.json | Bumped dependency versions for prettier-eslint and others |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 162 162
Branches 25 25
=========================================
Hits 162 162 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 90617e2 in 52 seconds. Click for details.
- Reviewed
53lines of code in2files - Skipped
1files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:54
- Draft comment:
Bump dependency versions: @prettier/eslint is updated to 17.0.0-alpha.1 (and glob, @changesets/cli, typescript-eslint bumped too). Verify these versions are fully compatible and no regressions are introduced. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. test/tests/cli.spec.js:105
- Draft comment:
Changed expected output in the stdin test from 'globalThis.baz' to 'window.baz'. Confirm that this change in formatting behavior is intentional with the new dependency version. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_67CidxdzIftqU9zM
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Signed-off-by: JounQin <[email protected]>
What:
Why:
How:
Important
Bump several dependencies in
package.jsonand update a test expectation incli.spec.js.@prettier/eslintto^17.0.0-alpha.1inpackage.json.globto^10.4.5,@changesets/clito^2.29.4, andtypescript-eslintto^8.32.1inpackage.json.accepts stdin of codetest incli.spec.jsto expectconsole.log(window.baz, typeof []);\ninstead ofconsole.log(globalThis.baz, typeof []);\n.This description was created by
for 90617e2. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Chores
Tests
window.bazexpression when processing stdin code.