fix: add support for missing prettier option jsxBracketSameLine

prettier · Dec 12, 2017 · a5f3d98 · a5f3d98
1 parent cb160a6
commit a5f3d98
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/__tests__/utils.js b/src/__tests__/utils.js
@@ -110,6 +110,11 @@ const getPrettierOptionsFromESLintRulesTests = [
     rules: { "comma-dangle": [2, "always-multiline"] },
     options: { trailingComma: "es5" }
   },
+  {
+    rules: {},
+    options: { jsxBracketSameLine: true },
+    fallbackPrettierOptions: { jsxBracketSameLine: true }
+  },
 
   // If an ESLint rule is disabled fall back to prettier defaults.
   { rules: { "max-len": [0, { code: 120 }] }, options: {} },

diff --git a/src/utils.js b/src/utils.js
@@ -43,6 +43,10 @@ const OPTION_GETTERS = {
   useTabs: {
     ruleValue: rules => getRuleValue(rules, "indent"),
     ruleValueToPrettierOption: getUseTabs
+  },
+  jsxBracketSameLine: {
+    ruleValue: () => RULE_NOT_CONFIGURED,
+    ruleValueToPrettierOption: getJsxBracketSameLine
   }
 };
 
@@ -264,6 +268,11 @@ function getUseTabs(eslintValue, fallbacks) {
   return makePrettierOption("useTabs", prettierValue, fallbacks);
 }
 
+function getJsxBracketSameLine(eslintValue, fallbacks) {
+  // TODO: add support for setting jsxBracketSameLine based on eslint config
+  return makePrettierOption("jsxBracketSameLine", eslintValue, fallbacks);
+}
+
 function extractRuleValue(objPath, name, value) {
   if (objPath) {
     logger.trace(