fix: tinyexec v1 is esm only, use 0.x instead #212
Conversation
JounQin
added
bug
🦋 Changeset detectedLatest commit: 86a3b82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe changes update configuration and workflow files to support the "4.x" branch and Node.js 24, adjust release tagging, and downgrade the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI Workflow
participant Node.js Matrix
participant Release Workflow
Developer->>CI Workflow: Pushes code to "4.x"
CI Workflow->>Node.js Matrix: Runs tests on Node.js 14/16/18/20/22/24
Developer->>Release Workflow: Pushes to "4.x"
Release Workflow->>Release Workflow: Publishes with tag "release-v4"
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR ensures compatibility by downgrading tinyexec from v1 (ESM-only) to the last CJS-supported v0.x release, and updates release branches and CI matrices for the new 4.x line.
- Pin
tinyexecpeer dependency to^0.3.2for CJS support. - Add
4.xas a release trigger and update the changeset base branch to4.x. - Include Node.js v24 in the CI test matrix.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Downgrade tinyexec to ^0.3.2 and tag releases as release-v4 in the release script. |
| .github/workflows/release.yml | Add 4.x to the list of branches that trigger the release workflow. |
| .github/workflows/ci.yml | Extend the Node.js version matrix to include v24. |
| .changeset/config.json | Change baseBranch from master to 4.x for new releases. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 956ae9d in 48 seconds. Click for details.
- Reviewed
47lines of code in3files - Skipped
2files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/ci.yml:25
- Draft comment:
Added Node 24 to the test matrix. Verify that tests run correctly on Node 24. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. .github/workflows/release.yml:6
- Draft comment:
Release workflow now triggers on branch '4.x' rather than 'master'. Ensure this aligns with your branch strategy for v4 releases. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to ensure that the change aligns with their branch strategy, which is against the rules. It doesn't provide a specific code suggestion or ask for a specific test to be written. Therefore, it should be removed.
3. package.json:65
- Draft comment:
Release script updated with '--tag release-v4'. Confirm that this tagging strategy meets your release versioning requirements. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm their tagging strategy, which is against the rules. It doesn't provide a specific suggestion or point out a clear issue with the code.
4. package.json:77
- Draft comment:
Dependency 'tinyexec' downgraded to '^0.3.2' to restore CommonJS compatibility. This fixes the ESM error (issue #211). - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining a change in dependency version to address a specific issue. It doesn't provide a suggestion or ask for confirmation about the change.
Workflow ID: wflow_9tZsh7cEfOiA8OqR
You can customize 
commit: |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #212 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 9 9
Lines 167 167
Branches 35 36 +1
=======================================
Hits 153 153
+ Misses 14 12 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
close #211
Important
Downgrade
tinyexecto^0.3.2, add Node.js 24 to CI, and update release workflow for4.xbranch.tinyexecfrom^1.0.1to^0.3.2inpackage.jsonto ensure compatibility.ci.yml.masterto4.xinrelease.yml.releasescript inpackage.jsonto use--tag release-v4.This description was created by
for 956ae9d. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit