fix(timer): validate issue key exists before starting a timer - #59
Merged
Conversation
`timer stop` only validated the issue key against Jira after computing duration, so a bad key on `timer start` left the timer entry stuck running forever (fixes #56). Validate up front in StartTimeEntry, matching the same pattern already used by `tl add`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
kimpepper
force-pushed
the
fix/timer-start-validate-issue-key
branch
from
July 31, 2026 01:29
e403299 to
5c54942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl timer start <bad-key>created a timer entry with no validationtimer stoponly checked the issue key against Jira after computing duration, right before persisting the final time entrytimer deleteStartTimeEntrynow callsSyncIssueup front and fails fast before mutating any timer state, matching the pattern already used bytl addFixes #56