Add a filter panel by mi-sts · Pull Request #196 · prime-slam/SOLVE

mi-sts · 2023-05-12T05:36:28Z

Close #42, close #43, close #181

Alexander-Ploskin · 2023-05-13T12:08:57Z

Problems:

Don't filter images if there are no filters, now user should add dumb filter manually if he doesn't need filters.
Filters is shared between different projects.
Filters is not applied when project was imported.
Filter data dropped when filter was disabled.
Show images with landmark doesn't work at all.
Multiple disable buttons on each layer.

Alexander-Ploskin · 2023-06-08T15:08:56Z

Problems:

It works great when all filters was removed, but it should also work this way when all filters was disabled, else user has to add dumb filter.
Nice to see that filter data was not dropped when I disable a filter, but this should also work when a user closes an editor.
0 value for "show every image" should not be allowed the same as negative values.
Filters disappear when I update any of them.

Alexander-Ploskin · 2023-06-08T15:13:22Z

src/main/kotlin/solve/SolveApp.kt

 import tornadofx.launch

-class SolveApp : App(MainView::class) {
+class SolveApp : App(MainView::class, ApplicationStylesheet::class) {


We already have global application style class Style.kt, can we merge them?

Alexander-Ploskin · 2023-06-08T15:18:19Z

src/main/kotlin/solve/constants/ResourcesPaths.kt

 const val IconsLayersFilled = "/icons/sidepanel/LayersFilled.png"
 const val IconsGrid = "/icons/sidepanel/Grid.png"
 const val IconsGridSelected = "/icons/sidepanel/GridSelected.png"


Create an issue to convert all icons to svg

Alexander-Ploskin · 2023-06-08T15:24:39Z

src/main/kotlin/solve/utils/materialfx/MFXNodesUtils.kt

+            return null
+        }
+
+        return constraints.first().message


Why only first?

When we adding a constraint for a message, it becomes a first element

Alexander-Ploskin · 2023-06-08T15:28:44Z

src/main/kotlin/solve/utils/materialfx/MFXNodesUtils.kt

+    rippleGenerator.clipSupplier = Supplier {
+        RippleClipTypeFactory(RippleClipType.CIRCLE).setRadius(radius).build(this)
+    }
+    style {


May be to global stylesheet?

I think it's better to leave it inside, because we have a radius parameter passed as an argument, which is needed for both the button and the ripple factory when button is pressed. It also ensures that no other set of styles will change the settings of the button created in this function.

Alexander-Ploskin · 2023-06-08T15:32:25Z

src/main/kotlin/solve/utils/materialfx/MFXNodeFactoriesUtils.kt

+    attachTo(this@controlButton, op)
+}
+
+fun EventTarget.dialogHeaderLabel(text: String, op: Label.() -> Unit = {}) = label(text) {


Use it also in ChooserDialog

Alexander-Ploskin · 2023-06-08T16:11:14Z

src/main/kotlin/solve/filters/view/FilterPanelFieldsView.kt

+                paddingRight = 20.5
+            }
+        )
+        Platform.runLater {


Are you sure, that it will work always?

Alexander-Ploskin · 2023-06-08T16:11:48Z

src/main/kotlin/solve/filters/view/FilterPanelFieldsView.kt

+            }
+        )
+        Platform.runLater {
+            val cellCheckbox = (cell.getChildList()?.firstOrNull { it is CheckBox } as? CheckBox) ?: return@runLater


May be singleOrNull?

Alexander-Ploskin · 2023-06-08T16:13:45Z

src/main/kotlin/solve/filters/view/FilterPanelFieldsView.kt

+                        // Needed because when an unselected element is removed,
+                        // the whole selection is recreated with the addition of the remaining elements,
+                        // which value changes causes changes of selectionProperty.


Did not understand at all :(

Alexander-Ploskin · 2023-06-08T16:16:50Z

src/main/kotlin/solve/filters/model/Filter.kt

+import solve.filters.settings.model.UIDFilterSetting
+import solve.project.model.ProjectFrame
+
+class Filter(val settings: List<FilterSetting<out Any>>) {


May be make it mutable to avoid problems with list view?

Alexander-Ploskin · 2023-06-08T16:18:15Z

src/main/kotlin/solve/filters/controller/FilterPanelController.kt

+        projectController.model.projectProperty.onChange {
+            applyFilters()


Is there any case when a lot of updates happen at once?

mi-sts · 2023-06-18T16:02:50Z

Problems:

...
4. Filters disappear when I update any of them.

This is a problem with the materialfx library, I tried to avoid this behavior for a long time, but nothing helped.

mi-sts requested review from Alexander-Ploskin and DmiitriyJarosh May 12, 2023 09:28

mi-sts added 27 commits May 16, 2023 17:31

Fix an incorrect initializaion of dividers positions

0b76808

Add a filters panel view

92daab0

Styling a controlsfx rangeslider for mfx design

14b4e6a

Create and customize validated integer text field

e657351

Codestyle

99bc3b9

Update filter settings dialog design and add a logic

9318fe2

Codestyle

5613fb4

Codestyle

d40b97b

Fix validation bugs

5b78f44

Add a filter applying logic

7a5d9fe

Fix a filter selection breaking bug

6ea64ee

Make filtered frames sorted in intial way

fb590f6

Fix bugs with checboxes selections and some design

5e0c745

Add a range slider uids visualization

126459d

Codestyle

8ae7c50

Trying to fix MFXListView bugs

7bcda61

Small fix

1a306fb

Fix validation bugs

de30c33

Remove redundant code

d7f80bf

Codestyle

f48d099

Small fix

c412bb0

Naming

9da6563

Refactor the filter setting class

52f5b6a

Codestyle

d0fe77c

Codestyle

bdaf679

Codestyle

9651b95

Fix bug with empty catalogue after a removing all filters

28e909a

mi-sts added 5 commits May 16, 2023 17:32

Keep text if textfield is empty

5d5dffa

Apply filters when reimport a project

e18552b

Fix bug with not working uids filter setting

7b08235

Codestyle

0cff312

Fix bug with two layer visibility buttons

953a44f

mi-sts force-pushed the filter-panel branch from 179565b to 953a44f Compare May 16, 2023 14:33

mi-sts added 2 commits May 16, 2023 22:23

Small fix

cd0342a

Fix bug with not working dragged catalogue files image

802c07f

Alexander-Ploskin suggested changes Jun 8, 2023

View reviewed changes

mi-sts added 2 commits June 18, 2023 18:31

Fix an all filters are disabled bug

5ca3090

Add logic for a saving unchecked settings

0a0bf4d

		projectController.model.projectProperty.onChange {
		applyFilters()

Conversation

mi-sts commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alexander-Ploskin commented May 13, 2023

Uh oh!

Alexander-Ploskin commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mi-sts commented Jun 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mi-sts commented May 12, 2023 •

edited

Loading

Alexander-Ploskin commented Jun 8, 2023 •

edited

Loading