fix: #18062 MultiSelect is removing previously selected values if sel… #18107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect all is checked after search
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Thank you for your contribution! We will review your PR shortly. Please make sure to manually link it to an issue for proper tracking. |
|
Thank you for your contribution! We will review your PR shortly. Please make sure to manually link it to an issue for proper tracking. |
rosenthalj
reviewed
Apr 18, 2025
| const optionValues = [...selectedDisabledOptions, ...visibleOptions].map((option) => this.getOptionValue(option)); | ||
| const selectedOptionsBeforeSearch = this.filter ? this.getAllVisibleAndNonVisibleOptions().filter((option) => this.isSelected(option) && this.isValidOption(option)) : []; | ||
|
|
||
| const optionValues = [...(!this.allSelected() ? selectedOptionsBeforeSearch : []), ...selectedDisabledOptions, ...visibleOptions].map((option) => this.getOptionValue(option)); | ||
| const value = [...new Set(optionValues)]; |
There was a problem hiding this comment.
For efficiency why not remove the conditional !this.allSelected() from const optionValues and update the conditional in const selectedOptionsBeforeSearch to (this.filter && !this.allSelected())
There was a problem hiding this comment.
I already refactored the code right after committing it. Thanks a lot for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18062