Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7775: Stepper fix typescript add children #7777

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

melloware
Copy link
Member

@melloware melloware commented Mar 11, 2025

Fix #7775: Stepper fix typescript add children
Fix #7800

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Mar 11, 2025
@melloware melloware merged commit c6b46c1 into primefaces:master Mar 11, 2025
3 checks passed
@melloware melloware deleted the PR7775 branch March 11, 2025 11:28
Copy link

vercel bot commented Mar 11, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@ignatiusomeje
Copy link

Please check this, as Vercel bot is saying that it failed in deployment and I think this has made us to not get the update even as it has been fixed and we've updated to the latest version

@melloware
Copy link
Member Author

@ignatiusomeje no you can see the ticket is marked for 10.9.4 which has not been released yet.

@ignatiusomeje
Copy link

ignatiusomeje commented Mar 14, 2025

@ignatiusomeje no you can see the ticket is marked for 10.9.4 which has not been released yet.

Okay sir, is there a way for it now as it makes my run build to fail?

@melloware
Copy link
Member Author

you have to wait for PrimeTek to release 10.9.4

@NADIRATIF
Copy link

@ignatiusomeje no you can see the ticket is marked for 10.9.4 which has not been released yet.

Okay sir, is there a way for it now as it makes my run build to fail?

can you share the part of the code where you using the stepper to help you fixed before the release

@melloware
Copy link
Member Author

@NADIRATIF are you asking if there is some kind of patch? No you have to wait for the 10.9.4 release.

@NADIRATIF
Copy link

@NADIRATIF are you asking if there is some kind of patch? No you have to wait for the 10.9.4 release.

I'm not requesting a patch. I need to see the original stepper implementation code to understand how the ref type is being used in @ignatiusomeje code This will allow me to provide a temporary workaround for the TypeScript issue until version 10.9.4 is released, enabling a successful build. I've encountered and resolved this problem myself previously, so I can offer a practical solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: Type error chlidren Stepper: TS2769: No overload matches this call
3 participants