Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InputText - updated condition to add 'p-filled' class to input element #7779

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

skj-skj
Copy link
Contributor

@skj-skj skj-skj commented Mar 11, 2025

Defect Fixes

FIx #7764 Updated condition in InputText to add p-filled class to input element.

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

@skj-skj skj-skj changed the title fix: #7764 updated condition to add 'p-filled' class to input element in InputText fix: InputText updated condition to add 'p-filled' class to input element Mar 11, 2025
@skj-skj skj-skj changed the title fix: InputText updated condition to add 'p-filled' class to input element fix: InputText - updated condition to add 'p-filled' class to input element Mar 11, 2025
@skj-skj
Copy link
Contributor Author

skj-skj commented Mar 11, 2025

@melloware, pls review.

@skj-skj
Copy link
Contributor Author

skj-skj commented Mar 11, 2025

here is the screen recording of the locally running stackblitz reproducer project as proof

inputtext-fix.mp4

Copy link

vercel bot commented Mar 11, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@melloware melloware merged commit d49a061 into primefaces:master Mar 11, 2025
6 of 7 checks passed
@skj-skj skj-skj deleted the inputtext branch March 11, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FloatLabel: inside Accordion misbehaves when dynamically adding/removing items
2 participants