fix(MultiSelect): #8102 - keyboard navigation and scrolling from wrapper #8351
+105
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from wrapper - Prevent page scroll on Space when wrapper has focus - ArrowUp/Down enter and move options from wrapper - Auto-scroll wrapper to keep focused option visible (both directions) - Escape closes and returns focus to trigger - Add onKeyDown+tabIndex to wrapper/virtual list; data-p-index on items
melloware
added
the
Status: Pending Review
Member
|
set to PrimeTek to review. |
Changed 'item' to 'processedItem' in menuitemProps onMouseEnter handler to match the expected parameter type and maintain consistency with other handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8102
This PR improves keyboard navigation and scrolling behavior in MultiSelect component:
Changes
Type of change
Testing
Please test keyboard navigation in MultiSelect component: