Skip to content

Fix #8449: Nested SplitterPanel detection logic #8448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melloware merged 3 commits into from
Dec 29, 2025
Merged

Fix #8449: Nested SplitterPanel detection logic #8448

melloware merged 3 commits into from
Dec 29, 2025
+58 −4

Conversation

@usrlocl
Copy link
Contributor

@usrlocl usrlocl commented Dec 28, 2025 •
edited by melloware
Loading

Current logic incorrectly identifies any nested Prime Component as a nested SplitterPanel causing incorrect behaviour. This change fixes that to identify SplitterPanel component only for such purpose.

Fix: #8449

@usrlocl
Fix: [Splitter] Nested SplitterPanel detection logic
234e468 
Current logic incorrectly identifies any nested Prime Component
as a nested SplitterPanel causing incorrect behaviour. This
change fixes that to identify SplitterPanel component only for
such purpose.
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@usrlocl usrlocl changed the title Fix: [Splitter] Nested SplitterPanel detection logic Fix: #8449: Nested SplitterPanel detection logic Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@usrlocl usrlocl changed the title Fix: #8449: Nested SplitterPanel detection logic Fix(Splitter) #8449: Nested SplitterPanel detection logic Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@usrlocl usrlocl changed the title Fix(Splitter) #8449: Nested SplitterPanel detection logic fix #8449: Nested SplitterPanel detection logic Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@usrlocl usrlocl changed the title fix #8449: Nested SplitterPanel detection logic Fix #8449: Nested SplitterPanel detection logic Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@usrlocl usrlocl marked this pull request as draft December 28, 2025 09:19
@usrlocl usrlocl marked this pull request as ready for review December 28, 2025 09:19
@usrlocl
Copy link
Contributor Author

usrlocl commented Dec 28, 2025

I'm unable to link this with the PR. The instructions in github don't work for some reason. But I've updated the title, hope that should do

@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Dec 28, 2025
@melloware
Copy link
Member

melloware commented Dec 28, 2025

Please run npm run format

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@usrlocl
Copy link
Contributor Author

usrlocl commented Dec 29, 2025

@melloware I've pushed a fix for formatting, but it's failing still for a different file I did not change. Would you like me to fix that as well and push?

@melloware
Copy link
Member

melloware commented Dec 29, 2025

Yes please let's get the build passing

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@usrlocl
Copy link
Contributor Author

usrlocl commented Dec 29, 2025

It's still failing for the linked issue, not sure why. Is this something you can check?

@melloware
Copy link
Member

melloware commented Dec 29, 2025

yeah that is flaky. Running the build now.

@melloware melloware merged commit 25faa90 into primefaces:master Dec 29, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melloware melloware melloware approved these changes

Assignees

No one assigned

Labels

Type: Bug Issue contains a defect related to a specific component.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Splitter: Incorrect detection of nested SplitterPanel

2 participants

@usrlocl @melloware