fix/InputNumber Fixes #7562 (change to initial value when delete last… #7772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altpebush6
force-pushed
the
fix/base-editable-holder
branch
from
d2c81b4 to
f26d365
Compare
…elete last character)…
altpebush6
force-pushed
the
fix/base-editable-holder
branch
from
f26d365 to
be47438
Compare
|
Hi 👋 Thanks for the fix — this issue is currently blocking us in production. Appreciate the great work from the team 🙏 |
|
Our entire production setup is also waiting for this merge. :) @mertsincan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug related to the InputNumber field in PrimeVue where, when attempting to delete the entire value using backspace, the field would revert back to its initial value. This issue is also reported in the official repository and can be referenced here: #7562
The problem originates from the formDefaultValue watcher inside the BaseEditableHolder file, where newValue is directly assigned to d_value. This causes the initial value to be automatically rewritten into the input field right after the last character is deleted.
To resolve this issue, I’ve modified the watcher so that d_value is updated with newValue only if the form has not yet been initialized, d_value is not null/undefined/empty, and d_value !== newValue. With this change, the issue no longer occurs.
Since this bug significantly affects our usage in our project, we would greatly appreciate it if this fix could be included in the upcoming Milestone 4.3.5.