Skip to content

Refactor pureCalculateAnchoredPosition to eliminate DOM dependency #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francinelucca merged 2 commits into from
Feb 2, 2026
Merged

Refactor pureCalculateAnchoredPosition to eliminate DOM dependency #683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
765619d
Initial plan
Copilot Feb 2, 2026
3fc4974
Refactor pureCalculateAnchoredPosition to accept viewport dimensions …
Copilot Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/anchored-position.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ export function getAnchoredPosition(
floatingElement.getBoundingClientRect(),
anchorElement instanceof Element ? anchorElement.getBoundingClientRect() : anchorElement,
getDefaultSettings(settings),
{width: window.innerWidth, height: window.innerHeight},
)
}

Expand Down Expand Up @@ -334,13 +335,15 @@ function getDefaultSettings(settings: Partial<PositionSettings> = {}): PositionS
* @param floatingRect WidthAndHeight for the floating element
* @param anchorRect BoxPosition for the anchor element
* @param PositionSettings to customize the calculated position for the floating element.
* @param visibleViewportSize Size of the visible viewport (window dimensions), used when displayInVisibleViewport is true
*/
function pureCalculateAnchoredPosition(
viewportRect: BoxPosition,
relativePosition: Position,
floatingRect: Size,
anchorRect: BoxPosition,
{side, align, allowOutOfBounds, anchorOffset, alignmentOffset, displayInVisibleViewport}: PositionSettings,
visibleViewportSize: Size,
): AnchorPosition {
// Compute the relative viewport rect, to bring it into the same coordinate space as `pos`
let effectiveViewportRect = viewportRect
Expand All @@ -350,8 +353,8 @@ function pureCalculateAnchoredPosition(
effectiveViewportRect = {
top: 0,
left: 0,
width: window.innerWidth,
height: window.innerHeight,
width: visibleViewportSize.width,
height: visibleViewportSize.height,
}
}

Expand Down
Loading