move flexsuite security recipe to category subfolder - #1341
Conversation
|
🟢 No design token changes found |
🟢 No unit test coverage changes foundAll components and hooks with tests maintain the same coverage as the main branch. |
There was a problem hiding this comment.
Pull request overview
Moves the Flexsuite Security recipe out of the “Overview” recipe group and into a new “Category” recipe group, aligning Storybook organization and e2e/visual test coverage with the intended template classification.
Changes:
- Removed the Security overview Storybook story and visual snapshot coverage from
recipes/FlexSuite/Overview. - Added a new
recipes/FlexSuite/CategorySecurity recipe (component, content, and Storybook story). - Updated Playwright visual-test generation timing and axe delay mappings to target the new Storybook story id, plus updated i18n strings.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/recipes/Flexsuite/Overview/index.ts | Stops exporting the removed Security overview entry. |
| packages/react/src/recipes/Flexsuite/Overview/Overview.visual.spec.ts | Removes the Security overview visual regression test case. |
| packages/react/src/recipes/Flexsuite/Overview/FlexSuiteSecurityOverview.stories.tsx | Removes the old Security overview Storybook story. |
| packages/react/src/recipes/Flexsuite/Category/index.ts | Adds barrel export for the new Security category recipe. |
| packages/react/src/recipes/Flexsuite/Category/FlexSuiteSecurityCategory.tsx | Introduces the new Security category recipe component/template. |
| packages/react/src/recipes/Flexsuite/Category/FlexSuiteSecurityCategory.stories.tsx | Adds Storybook story under Recipes/FlexSuite/Category with id recipes-flexsuite-category--security. |
| packages/react/src/recipes/Flexsuite/Category/FlexSuiteSecurityCategory.content.ts | Adds/renames content model + localized content getter for the new category recipe. |
| packages/react/src/recipes/Flexsuite/Category/Category.visual.spec.ts | Adds visual regression coverage for the new Category story (but currently includes an unrelated SEO story too). |
| packages/e2e/scripts/playwright/playwright.generate-tests.ts | Updates the per-story timeout lookup key to the new Storybook id. |
| packages/e2e/scripts/playwright/axe-clean.spec.ts | Updates custom axe delay mapping to the new Storybook id. |
| apps/storybook/static/locales/*/FlexSuiteSecurityCategory.json | Updates localized strings referencing “overview” → “category”. |
Copilot's findings
- Files reviewed: 16/17 changed files
- Comments generated: 1
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
danielguillan
left a comment
There was a problem hiding this comment.
Looks good. We just need to remove the log file that was committed by mistake.
Summary
Towards https://github.com/github/brand-marketing-design/issues/2606
Moves the security recipe to a new catgory template folder. It was incorrectly considered an overview template before.
List of notable changes:
Steps to test:
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist:
Screenshots: