[Brand Refactor] River and RiverAccordion updates - #1365
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 971bd4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🟢 No design token changes found |
🟢 Bundle size report
|
🟢 Unit test coverage changes foundUnit test coverage has been updated through this PR. Changes: 0 new tests, 0 removed tests, 1 improved, 1 decreased
|
There was a problem hiding this comment.
Pull request overview
This PR refines the River and RiverAccordion “gridline” tablet layout (constrained max-width + lateral gridlines), makes the gridline visual background full-bleed by default, and removes the imageBackgroundColor prop from River.Visual as a breaking change. It also updates RiverAccordion’s toggle icon from chevrons to triangles and adds/updates visual regression coverage for tablet scenarios.
Changes:
- Remove
imageBackgroundColorfromRiver.Visualand apply the background styling automatically forRiver variant="gridline". - Update River/RiverAccordion gridline tablet styling (max-width + lateral borders) and adjust spacing.
- Update RiverAccordion toggle icons + refresh unit/visual tests and Storybook stories for new behaviors.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/river/RiverBreakoutTabs/RiverBreakoutTabs.tsx | Reintroduces imageBackgroundColor support on RiverBreakoutTabs.Visual via a wrapper class toggle. |
| packages/react/src/river/RiverBreakoutTabs/RiverBreakoutTabs.examples.stories.tsx | Removes imageBackgroundColor usage from River.Visual inside gridline Rivers in examples. |
| packages/react/src/river/RiverBreakout/RiverBreakout.tsx | Adds a Visual wrapper so RiverBreakout.Visual can still accept imageBackgroundColor. |
| packages/react/src/river/RiverAccordion/RiverAccordion.visual.spec.ts | Adds a tablet-viewport visual regression test for the gridline tablet story. |
| packages/react/src/river/RiverAccordion/RiverAccordion.tsx | Switches accordion toggle icons from chevrons to triangles. |
| packages/react/src/river/RiverAccordion/RiverAccordion.test.tsx | Updates assertions to match new triangle octicon classnames. |
| packages/react/src/river/RiverAccordion/RiverAccordion.module.css | Adjusts breakpoints and adds tablet-only constrained layout + lateral borders for gridline. |
| packages/react/src/river/RiverAccordion/RiverAccordion.gridline.stories.tsx | Adds a dedicated “Gridline (tablet)” story using an iPad viewport preset. |
| packages/react/src/river/River/River.visual.spec.ts | Adds a tablet-viewport visual regression test and renames gridline tests to “default background”. |
| packages/react/src/river/River/River.tsx | Applies the background class to River.Visual automatically when variant="gridline"; removes the prop from RiverVisualProps. |
| packages/react/src/river/River/River.test.tsx | Updates unit tests for the new default background behavior and className preservation. |
| packages/react/src/river/River/River.gridline.stories.tsx | Updates Gridline stories to remove imageBackgroundColor usage and adds a tablet story. |
| packages/react/src/river/River/River.examples.stories.tsx | Removes imageBackgroundColor usage and updates explanatory copy. |
| packages/react/src/river/river-shared.module.css | Adds tablet max-width + lateral borders for gridline variant and adjusts CTA spacing. |
| packages/react/src/recipes/Flexsuite/Overview/FlexSuiteAIOverview.tsx | Migrates gridline Rivers off imageBackgroundColor usage. |
| apps/next-docs/content/components/River/react.mdx | Updates docs for the breaking change by removing the “Visual with background” section and the prop row. |
| .changeset/silver-pandas-draw.md | Adds a patch changeset for RiverAccordion tablet layout/icon update. |
| .changeset/quiet-otters-dance.md | Adds a minor changeset documenting the breaking change + tablet gridline updates. |
Copilot's findings
- Files reviewed: 18/80 changed files
- Comments generated: 3
|
@copilot please fix the branch conflicts |
Conflicts are fixed by merging |
|
@copilot resolve the merge conflicts in this pull request |
Resolved and merged in commit |
| }) | ||
|
|
||
| it('applies the visual background class when imageBackgroundColor is set', () => { | ||
| it('does not apply the removed visual background treatment by default', () => { |
There was a problem hiding this comment.
FYI this test is no longer relevant and should be removed instead of inverting it

Summary
Addresses QA feedback for
RiverandRiverAccordion, including spacing/layout refinements, gridline behavior updates, and theRiver.Visualprop removal.List of notable changes:
RiverandRiverAccordion, including tablet constrained layouts with lateral gridlines for gridline variants.River variant="gridline"now applies full-bleed visual background behavior by default.imageBackgroundColorfromRiver.Visual.What should reviewers focus on?
Riverspacing, visual background behavior, and lateral gridlines across desktop, tablet, and mobile.Riverstart, end, center, and60:40gridline layouts still align content and visuals correctly.Steps to test:
Components/River/Features/GridLine variants(tablet, centered, end-aligned, and60:40).Rivergridline visual background is full-bleed by default and tablet layouts are constrained with lateral gridlines.Components/RiverAccordion/Features/Gridline variantsand verify default/end-aligned/tablet layouts.Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist:
Screenshots: