-
Notifications
You must be signed in to change notification settings - Fork 67
RiverBreakoutTabs + Card layout adjustments #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
11673f2
design adjustments to river breakout tabs and card
rezrah d24da0d
Merge branch 'main' of github.com:primer/brand into rezrah/brand-refa…
rezrah 1a6ef73
address feedback
rezrah 38460fd
Merge branch 'main' into rezrah/brand-refactor-qa-fixes-jul-8
rezrah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react-brand': patch | ||
| --- | ||
|
|
||
| Reduced the spacing between the `Card` description and its link from `32px` to `24px` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| '@primer/react-brand': patch | ||
| --- | ||
|
|
||
| Updates to the `RiverBreakoutTabs` component: | ||
|
|
||
| - Reduced the spacing above the tab list action on wide breakpoints from `16px` to `12px` | ||
| - Reduced the gridline outer padding from `64px` to `60px` at the widest breakpoint | ||
| - Added a `0.3s` transition to the tab heading color | ||
| - Fixed a shadow-border issue on hovered tab indicators. It now fills the entire parent space using a negative offset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-186 Bytes
(100%)
....visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Align-center-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-858 Bytes
(99%)
...ual.spec.ts-snapshots/Visual-Comparison-Card-Card-Background-color-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...d/Card.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Border-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...Card.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-CTA-Text-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
.../Card.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Default-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-134 Bytes
(100%)
...ard.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Editorial-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-67 Bytes
(100%)
...rd.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Full-Width-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...ard/Card.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Icon-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...isual.spec.ts-snapshots/Visual-Comparison-Card-Card-Icon-And-Label-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...snapshots/Visual-Comparison-Card-Card-Icon-And-Label-With-Fragment-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-466 Bytes
(100%)
...d.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Icon-Colors-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...d.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Icon-native-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...rd/Card.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Image-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...sual.spec.ts-snapshots/Visual-Comparison-Card-Card-Image-And-Label-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...-snapshots/Visual-Comparison-Card-Card-Image-Using-Picture-Element-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...rd/Card.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Label-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...al.spec.ts-snapshots/Visual-Comparison-Card-Card-Label-accent-text-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4 Bytes
(100%)
.../Card.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Minimal-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7 Bytes
(100%)
....visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Minimal-Dark-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...rd.visual.spec.ts-snapshots/Visual-Comparison-Card-Card-Playground-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-92 Bytes
(100%)
....ts-snapshots/Visual-Comparison-Card-Card-With-Inline-Code-Element-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
...pec.ts-snapshots/Visual-Comparison-Card-Card-With-block-end-tokens-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...son-Card-Card-With-inline-code-element-non-standard-size-overrides-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-66 Bytes
(100%)
...sual.spec.ts-snapshots/Visual-Comparison-Hero-Hero-Hero-with-cards-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-119 Bytes
(100%)
...mparison-FeaturePreviewLevelTwo-FeaturePreviewLevelTwo-2-1-variant-1-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-254 Bytes
(100%)
...mparison-FeaturePreviewLevelTwo-FeaturePreviewLevelTwo-2-3-variant-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-64 Bytes
(100%)
...mparison-FeaturePreviewLevelTwo-FeaturePreviewLevelTwo-2-4-variant-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-61 Bytes
(100%)
...omparison-FeaturePreviewLevelTwo-FeaturePreviewLevelTwo-Playground-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-58 Bytes
(100%)
...pec.ts-snapshots/Visual-Comparison-FlexSection-FlexSection-Default-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+218 Bytes
(100%)
...c.ts-snapshots/Visual-Comparison-FlexTemplate-FlexTemplate-Default-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-3.41 KB
(100%)
...isual.spec.ts-snapshots/Visual-Comparison-examples-examples-Agents-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-240 Bytes
(100%)
....ts-snapshots/Visual-Comparison-examples-examples-Copilot-Business-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+1.37 KB
(100%)
...spec.ts-snapshots/Visual-Comparison-CategoryPage-CategoryPage-Dark-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-191 Bytes
(100%)
...pec.ts-snapshots/Visual-Comparison-CategoryPage-CategoryPage-Light-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-45 Bytes
(100%)
...spec.ts-snapshots/Visual-Comparison-Industry-Industry-Maximum-Dark-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-68 Bytes
(100%)
...pec.ts-snapshots/Visual-Comparison-Industry-Industry-Maximum-Light-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-53 Bytes
(100%)
...spec.ts-snapshots/Visual-Comparison-Industry-Industry-Minimum-Dark-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-54 Bytes
(100%)
...pec.ts-snapshots/Visual-Comparison-Industry-Industry-Minimum-Light-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-65 Bytes
(100%)
....visual.spec.ts-snapshots/Visual-Comparison-Size-Size-Maximum-Dark-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-89 Bytes
(100%)
...visual.spec.ts-snapshots/Visual-Comparison-Size-Size-Maximum-Light-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-100 Bytes
(100%)
....visual.spec.ts-snapshots/Visual-Comparison-Size-Size-Minimum-Dark-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-166 Bytes
(100%)
...visual.spec.ts-snapshots/Visual-Comparison-Size-Size-Minimum-Light-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-48 Bytes
(100%)
...l.spec.ts-snapshots/Visual-Comparison-UseCase-UseCase-Maximum-Dark-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-40 Bytes
(100%)
....spec.ts-snapshots/Visual-Comparison-UseCase-UseCase-Maximum-Light-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-63 Bytes
(100%)
...l.spec.ts-snapshots/Visual-Comparison-UseCase-UseCase-Minimum-Dark-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-65 Bytes
(100%)
....spec.ts-snapshots/Visual-Comparison-UseCase-UseCase-Minimum-Light-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-106 Bytes
(100%)
...apshots/Visual-Comparison-SolutionsOverview-SolutionsOverview-Dark-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-33 Bytes
(100%)
...pshots/Visual-Comparison-SolutionsOverview-SolutionsOverview-Light-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-90 Bytes
(100%)
...isual.spec.ts-snapshots/Visual-Comparison-Article-Article-Ai-Theme-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-82 Bytes
(100%)
...l.spec.ts-snapshots/Visual-Comparison-Article-Article-All-Headings-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-850 Bytes
(100%)
...ts-snapshots/Visual-Comparison-Article-Article-Collaboration-Theme-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+667 Bytes
(100%)
...pec.ts-snapshots/Visual-Comparison-Article-Article-Dark-Hero-Image-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-82 Bytes
(100%)
...ec.ts-snapshots/Visual-Comparison-Article-Article-Enterprise-Theme-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+17 Bytes
(100%)
...ec.ts-snapshots/Visual-Comparison-Article-Article-Light-Hero-Image-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-40 Bytes
(100%)
...ual.spec.ts-snapshots/Visual-Comparison-Article-Article-Playground-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-103 Bytes
(100%)
....ts-snapshots/Visual-Comparison-Article-Article-Productivity-Theme-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-83 Bytes
(100%)
...spec.ts-snapshots/Visual-Comparison-Article-Article-Security-Theme-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-138 Bytes
(100%)
...l.spec.ts-snapshots/Visual-Comparison-Category-Category-Playground-1-darwin.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+0 Bytes
(100%)
...utTabs-Mobile-vi-1dfbf--viewport-RiverBreakoutTabs-Narrow-viewport-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...ual-Comparison-RiverBreakoutTabs-RiverBreakoutTabs-Controlled-Mode-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+674 Bytes
(100%)
...hots/Visual-Comparison-RiverBreakoutTabs-RiverBreakoutTabs-Default-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-42.1 KB
(84%)
...n-RiverBreakoutTabs-RiverBreakoutTabs-Full-bleed-background-visual-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
...ts/Visual-Comparison-RiverBreakoutTabs-RiverBreakoutTabs-Two-Items-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+21 Bytes
(100%)
...l-Comparison-RiverBreakoutTabs-RiverBreakoutTabs-Uncontrolled-Mode-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-57 Bytes
(100%)
...parison-RiverBreakoutTabs-RiverBreakoutTabs-With-Background-Visual-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+1.81 KB
(100%)
.../Visual-Comparison-RiverBreakoutTabs-RiverBreakoutTabs-With-images-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+3.09 KB
(100%)
.../Visual-Comparison-RiverBreakoutTabs-RiverBreakoutTabs-With-rivers-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+14 KB
(100%)
.../Visual-Comparison-RiverBreakoutTabs-RiverBreakoutTabs-With-videos-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+34 Bytes
(100%)
...omparison-RiverBreakoutTabs-RiverBreakoutTabs-Without-Action-Links-1-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+0 Bytes
(100%)
...utTabs-Tablet-vi-0855d--viewport-RiverBreakoutTabs-Tablet-viewport-1-darwin.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move these updated values to design tokens please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielguillan are you looking to update the existing token values, which will impact multiple components or add new ones for RiverBreakoutTabs?
I'd rather avoid scope creeping by changing RiverBreakout right now. Adding an entire component token file just for two overrides feels a bit heavy handed, though I do see your argument for hoisting these. Can you clarify the intent first please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are already defined and scoped to RiverBreakout so these lines are only overriding the existing tokens rather than defining new ones, right? Or maybe I'm missing something, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting for posterity that we resolved this in DMs. we'll leave hoisting these as the tokens touch 2 different river breakout components.