Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/card-description-link-spacing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react-brand': patch
---

Reduced the spacing between the `Card` description and its link from `32px` to `24px`
10 changes: 10 additions & 0 deletions .changeset/river-breakout-tabs-wide-action-spacing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'@primer/react-brand': patch
---

Updates to the `RiverBreakoutTabs` component:

- Reduced the spacing above the tab list action on wide breakpoints from `16px` to `12px`
- Reduced the gridline outer padding from `64px` to `60px` at the widest breakpoint
- Added a `0.3s` transition to the tab heading color
- Fixed a shadow-border issue on hovered tab indicators. It now fills the entire parent space using a negative offset.
2 changes: 1 addition & 1 deletion packages/react/src/Card/Card.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@
}

.Card__description {
margin-block-end: var(--base-size-32);
margin-block-end: var(--base-size-24);
grid-area: description;
}

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@
}
}

@media screen and (min-width: 80rem) {
.RiverBreakoutTabs {
--brand-RiverBreakout-variant-gridline-spacing-outerInline: var(--base-size-60);
--brand-RiverBreakout-variant-gridline-spacing-outerBlock: var(--base-size-60);
Comment on lines +15 to +16

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these updated values to design tokens please?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielguillan are you looking to update the existing token values, which will impact multiple components or add new ones for RiverBreakoutTabs?

I'd rather avoid scope creeping by changing RiverBreakout right now. Adding an entire component token file just for two overrides feels a bit heavy handed, though I do see your argument for hoisting these. Can you clarify the intent first please.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are already defined and scoped to RiverBreakout so these lines are only overriding the existing tokens rather than defining new ones, right? Or maybe I'm missing something, sorry.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting for posterity that we resolved this in DMs. we'll leave hoisting these as the tokens touch 2 different river breakout components.

}
}

.RiverBreakoutTabs__accordion {
display: flex;
flex-direction: column;
Expand Down Expand Up @@ -143,20 +150,21 @@
}

.RiverBreakoutTabs__item--selected::before {
transform: scaleY(2);
transform: translateY(calc(-1 * var(--brand-borderWidth-thin))) scaleY(2);
background-color: var(--brand-color-accent-primary);
}

@media screen and (min-width: 63.25rem) and (hover: hover) and (pointer: fine) {
.RiverBreakoutTabs__item:hover::before {
transform: scaleY(2);
transform: translateY(calc(-1 * var(--brand-borderWidth-thin))) scaleY(2);
background-color: var(--brand-color-accent-primary);
}
}

.RiverBreakoutTabs__heading {
margin: 0;
color: var(--brand-color-text-muted);
transition: color var(--brand-animation-duration-fast) ease-in-out;
}

.RiverBreakoutTabs__item--selected .RiverBreakoutTabs__heading {
Expand Down Expand Up @@ -214,7 +222,7 @@
}

.RiverBreakoutTabs__wideTabListActionItem {
margin-block-start: var(--base-size-16);
margin-block-start: var(--base-size-12);
}

.RiverBreakoutTabs__content {
Expand Down Expand Up @@ -271,13 +279,13 @@
}

.RiverBreakoutTabs__accordionItem.RiverBreakoutTabs__item--selected::before {
transform: scaleY(2);
transform: translateY(calc(-1 * var(--brand-borderWidth-thin))) scaleY(2);
background-color: var(--brand-color-accent-primary);
}

@media (hover: hover) and (pointer: fine) {
.RiverBreakoutTabs__accordionItem:hover::before {
transform: scaleY(2);
transform: translateY(calc(-1 * var(--brand-borderWidth-thin))) scaleY(2);
background-color: var(--brand-color-accent-primary);
}
}
Expand Down
Loading