-
Notifications
You must be signed in to change notification settings - Fork 67
Hero batch updates: Add ActionMenu to Hero and ButtonGroup changes, full-bleed media and more #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
185ddcd
Add ActionMenu to Hero and ButtonGroup changes
rezrah d6a242a
add feedback
rezrah 5a351d6
Merge branch 'main' of github.com:primer/brand into rezrah/add-native…
rezrah d18ec44
make secondary the default 2nd button variant
rezrah 58c5e66
Merge branch 'main' into rezrah/add-native-actionmenu-hero
rezrah af5973b
Merge branch 'main' of github.com:primer/brand into rezrah/add-native…
rezrah 31b685f
fix test ci
rezrah 224484b
Merge branch 'rezrah/add-native-actionmenu-hero' of github.com:primer…
rezrah b0a07a1
decouple the padding and position for hero media
rezrah d97395c
add full-bleed river
rezrah 279136d
fix merge conflict
rezrah 18229dc
fix snapshots from previous pr
rezrah 7aec788
address design feeback
rezrah ef204ef
Revert RiverBreakout gridline background and padding
danielguillan 9e9d80e
Reconcile RiverBreakout revert artifacts
rezrah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| '@primer/react-brand': patch | ||
| --- | ||
|
|
||
| Added `Hero.ButtonGroup` for rendering `Button` and `ActionMenu` children. `Hero.ButtonGroup` is now the de facto way to display buttons in the `Hero`. | ||
|
|
||
| ⚠️ `Hero.PrimaryAction` and `Hero.SecondaryAction` are now deprecated. Please migrate over to `Hero.ButtonGroup` as they will be removed in a future release. | ||
|
|
||
| Migrate using the following approach: | ||
|
|
||
| ```diff | ||
| -<Hero.PrimaryAction href="#">Primary action</Hero.PrimaryAction> | ||
| -<Hero.SecondaryAction href="#">Secondary action</Hero.SecondaryAction> | ||
| +<Hero.ButtonGroup> | ||
| + <Button as="a" href="#"> | ||
| + Primary action | ||
| + </Button> | ||
| + <Button as="a" href="#"> | ||
| + Secondary action | ||
| + </Button> | ||
| +</Hero.ButtonGroup> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| 'use client' | ||
| import {PropTableValues} from '@primer/doctocat-nextjs/components' | ||
|
|
||
| export const ButtonGroupSizesProp = () => <PropTableValues values={['medium', 'large']} commaSeparated /> | ||
| export const ButtonGroupSizesProp = () => <PropTableValues values={['small', 'medium', 'large']} commaSeparated /> | ||
| export const ButtonGroupAsProp = () => <PropTableValues values={['button', 'a']} commaSeparated /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.