Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default link color to Timeline.Item text #533

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Feb 7, 2024

Summary

Adds a default color to inline links used in Timeline.Item. Link color matches the appearance of our existing InlineLink.

What should reviewers focus on?

  • Implementation approach

Steps to test:

  1. Review this new Storybook story.

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

Screenshot 2024-02-07 at 16 33 08

Screenshot 2024-02-07 at 12 13 32

Copy link

changeset-bot bot commented Feb 7, 2024

🦋 Changeset detected

Latest commit: 14dacba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 7, 2024

🟢 No design token changes found

Copy link
Contributor

@auareyou auareyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Copy link
Contributor

github-actions bot commented Feb 7, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah merged commit 143c4f8 into main Feb 9, 2024
14 of 15 checks passed
@rezrah rezrah deleted the rezrah/links-in-timeline branch February 9, 2024 14:39
@primer-css primer-css mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants