Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x variant to unordered lists, and leadingVisual, variant and color props to list items #534

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Feb 16, 2024

Summary

Resolves #527

Adds granular control over list appearance.

🔗 Storybook examples

List of notable changes:

  • added variant="x" prop to UnorderedList component.
  • added variant prop to ListItem component, to allow alternating between default and muted colors
  • added leadingVisual prop to ListItem to allow custom icon overrides
  • added leadingVisualFill prop to ListItem to allow custom icon colors
  • added leadingVisualAriaLabel prop to ListItem to allow aria labels to be forwarded to the icon

Steps to test:

  1. Open and review the following storybook stories
  2. Review the updated documentation

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Screenshot 2024-02-16 at 12 25 11 Screenshot 2024-02-16 at 12 25 19 Screenshot 2024-02-16 at 12 25 16

Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: dd85369

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

🟢 No design token changes found

Copy link
Contributor

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rezrah rezrah merged commit f196cea into main Feb 20, 2024
16 of 17 checks passed
@rezrah rezrah deleted the rezrah/leading-icon-list branch February 20, 2024 09:38
@primer-css primer-css mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Allow custom icon in UnorderedList.Item
2 participants