Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface guidelines for river breakout content length #537

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Feb 19, 2024

Adds content length guidance and do's and don'ts for river breakout.

Docs preview

Copy link

changeset-bot bot commented Feb 19, 2024

⚠️ No Changeset found

Latest commit: add8643

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 19, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Feb 19, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

Copy link
Contributor

@auareyou auareyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@nsolerieu nsolerieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great do/dont visual examples

@danielguillan danielguillan merged commit 49e2d58 into main Feb 22, 2024
16 of 17 checks passed
@danielguillan danielguillan deleted the danielguillan/update-river-breakout-guidelines branch February 22, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants