Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #543

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Release tracking #543

merged 1 commit into from
Mar 4, 2024

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Mar 1, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Patch Changes

  • #541 392d4c4 Thanks @danielguillan! - Adds hover states to the social icon links in MinimalFooter

  • #542 79fa589 Thanks @rezrah! - - Added new size option to ActionMenu

    • Improved, automatic overlay positioning dependent on the action menu's location in the viewport.

    Example:

    <>
      <ActionMenu size="small">
        <ActionMenu.Button>Small</ActionMenu.Button>
        <ActionMenu.Overlay aria-label="Menu items">
          <ActionMenu.Item value="Item 1">Item 1</ActionMenu.Item>
          <ActionMenu.Item value="Item 2">Item 2</ActionMenu.Item>
        </ActionMenu.Overlay>
      </ActionMenu>
      <ActionMenu size="medium">
        <ActionMenu.Button>Medium</ActionMenu.Button>
        <ActionMenu.Overlay aria-label="Menu items">
          <ActionMenu.Item value="Item 1">Item 1</ActionMenu.Item>
          <ActionMenu.Item value="Item 2">Item 2</ActionMenu.Item>
        </ActionMenu.Overlay>
      </ActionMenu>
    </>

    🔗 See the documentation for more examples

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

Copy link
Contributor

github-actions bot commented Mar 1, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Mar 1, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

@primer-css primer-css force-pushed the changeset-release/main branch from 026452f to 08993f4 Compare March 1, 2024 17:04
@primer-css primer-css force-pushed the changeset-release/main branch from 08993f4 to cc76a46 Compare March 4, 2024 09:05
@rezrah
Copy link
Collaborator

rezrah commented Mar 4, 2024

Smoke test results

Both tested in Resources Hub

✅ Adds hover states to the social icon links in MinimalFooter

✅ Added new size option to ActionMenu (requires setting the dir attribute, which is currently missing in main) cc. @egim

Screenshot 2024-03-04 at 10 49 18

@rezrah rezrah merged commit 9ba7e4f into main Mar 4, 2024
17 of 18 checks passed
@rezrah rezrah deleted the changeset-release/main branch March 4, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants