Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #916

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Release tracking #916

merged 1 commit into from
Feb 13, 2025

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Feb 3, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Patch Changes

  • #901 d9a95b2 Thanks @rezrah! - Updated the following library depedencies: @oddbird/popover-polyfill, autoprefixer, css-loader, mini-css-extract-plugin, postcss, postcss-loader, postcss-preset-env, style-loader, typed-css-modules, typescript-plugin-css-modules, webpack-cli, fast-glob.

    These updates should not affect the library’s visuals or component APIs. In most cases, no additional action is required. Please note however, that the compiled output may be slightly different due to changes in the bundling process.

  • #912 5966728 Thanks @joshfarrant! - Fixed a bug in the ActionMenu component where items with falsy values (eg "") would not trigger the onSelect callback when selected.

  • #909 c5f2d40 Thanks @danielguillan! - Increased the gap between primary and secondary buttons in Hero, CTABanner and ButtonGroup components from 8px to 16px.

  • #918 65f7a92 Thanks @rezrah! - Fix RiverStoryScroll scrolling bug when disabled={true}. Now renders children 1:1.

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

Copy link
Contributor

github-actions bot commented Feb 3, 2025

❗ Pre-merge checklist

Please ensure these items are checked before merging.

✅ Preliminary checks

  • All CI checks pass on this pull request
  • Docs and Storybook previews open in a browser

🔌 Integration smoke tests

Dotcom

  • Performed successful integration test with github/github, as a primary consumer of Primer Brand
    • Install RC: bin/npm install --save --save-exact @primer/react-brand@{RC_VERSION}
      Important: Verify that each workspace package has been updated correctly in their respective package.json files
    • Run development server
    • Manually verify release-specific bugfixes and/or features on the following pages:
      • /features/copilot
      • /features/copilot/getting-started
      • /features/preview
      • /enterprise
      • /enterprise/advanced-security
      • /enterprise/contact
      • /articles/security
      • /articles/security/what-is-security-testing
      • /solutions/devops
      • /education
      • /mobile
      • /about/diversity
      • /newsroom
      • /resources/articles
      • /resources/articles/software-development
      • /resources/articles/software-development/what-is-cloud-native
      • /resources/whitepapers
      • /resources/whitepapers/how-the-c-suite-can-lead-ai-innovation
      • /solutions
      • /solutions/use-case/
      • /solutions/use-case/devops
    • Manually compare production site to local instance for any non-release specific regressions

Subdomain sites

  • Performed successful integration test with githubuniverse.com, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • Run development server and verify no new console warnings or regressions are found
    • Run local build to verify the release compiles correctly
    • Manually performed side-by-side comparison with production
  • Performed successful integration test with https://resources.github.com/, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • Run development server and verify no new console warnings or regressions are found
    • Run local build to verify the release compiles correctly
    • Manually performed side-by-side comparison with production

Sandboxes

  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Cross-check (aka sanity test)

  • Release notes accurately describe the changes made
  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions or side-effects have not been introduced as a result of changes in this release.
    • If they have, determine severity of the issue and consider hotfixing

After tests

  • Add report summary of your findings, including any images. Use following template as a guide:

    #### Smoke test results
    
    - Feature 1 🟢 🟡 🔴 (choose one, depending on success levels)
    
      {insert screenshot}
    
    Release testing status: Ready to release 🟢 | Paused 🟡 🔴 (choose one and provide reason)

🚢 After merge

  • Issue release comms in primer brand Slack channel
  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Copy link
Contributor

github-actions bot commented Feb 3, 2025

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Feb 3, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah
Copy link
Collaborator

rezrah commented Feb 13, 2025

Smoke test results

  • Updated library dependencies 🔴

    Error using latest clsx dependency at v2 in dotcom. Dotcom pegged to v1 in react core, so we'll need to downgrade ours to match. Requires hotfix.

  • Fix RiverStoryScroll scrolling bug when disabled={true} 🔴

    Not working as expected. Opened a fix in Release fixes #925

Release testing status: Paused 🔴

@rezrah
Copy link
Collaborator

rezrah commented Feb 13, 2025

Smoke test results

  • Updated library dependencies 🟢

    Previous npm installation errors resolved. clsx now matches dotcom's managed dependency.

  • Fix RiverStoryScroll scrolling bug when disabled={true} 🟢

    Hotfix resolves the previous issue. Now works as expected:

    RiverStoryScroll disabled RiverStoryScroll enabled
    Screen.Recording.2025-02-13.at.16.16.28.mov
    Screen.Recording.2025-02-13.at.16.17.15.mov
  • ActionMenu component accepts falsy values 🟢

    Works as expected. Triggers on selection handler when value of "" is passed

    Screenshot 2025-02-13 at 16 23 49
    Screenshot 2025-02-13 at 16 23 56

  • Increased the gap between primary and secondary buttons in Hero, CTABanner and ButtonGroup components from 8px to 16px. 🟢

Works as expected on all standard Hero components. Doesn't apply to any custom implementations of it, but that is also expected.

Screenshot 2025-02-13 at 16 26 53

  • Performed successful integration test with githubuniverse.com, as a Tier 1 consumer of Primer Brand outside of the monolith. 🟢

    Tested on asset generator as the most high-profile subdomain site user

Release testing status: Good to go 🟢

@rezrah rezrah merged commit 0ba9b1f into main Feb 13, 2025
18 checks passed
@rezrah rezrah deleted the changeset-release/main branch February 13, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants