Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Rails implementation only" copy from IconButton tooltip documentation #927

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Remove "Rails implementation only" copy from IconButton tooltip documentation #927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/components/icon-button.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ The selectable variant/scheme colors meet minimum color contrast requirements.

The size variants all meet the minimum target size requirement.

In the Rails implementation, `IconButton` automatically has a visible tooltip that appears when the button is hovered and when it receives keyboard focus. The tooltip visually replicates the accessible name of the button. The tooltip can be hovered when using the mouse, and can be dismissed using `Esc` without needing to move the mouse or focus away from the button.
`IconButton` automatically has a visible tooltip that appears when the button is hovered and when it receives keyboard focus. The tooltip visually replicates the accessible name of the button. The tooltip can be hovered when using the mouse, and can be dismissed using `Esc` without needing to move the mouse or focus away from the button.

### Implementation requirements

Expand Down Expand Up @@ -88,7 +88,7 @@ Make sure to differentiate icon buttons through the use of sufficiently differen
- Unless the button is `disabled`, it can be focused and activated using the keyboard
- If the button is set to be `inactive`, it still receives keyboard focus, but it conveys its inactive/disabled state to screen readers with the `aria-disabled="true"` attribute
- The button has a minimum target size of 24×24 CSS pixels, regardless of content
- For the Rails implementation, the tooltip for the button can be hovered with the mouse, and the tooltip can be dismissed using `Esc` without needing to move the mouse or focus away from the button
- The tooltip for the button can be hovered with the mouse, and the tooltip can be dismissed using `Esc` without needing to move the mouse or focus away from the button

### Known accessibility issues (GitHub staff only)

Expand Down
Loading