Addition of lockup icon, adjustments to logo and mark#1165
Merged
francinelucca merged 8 commits intoprimer:mainfrom Mar 18, 2026
Merged
Addition of lockup icon, adjustments to logo and mark#1165francinelucca merged 8 commits intoprimer:mainfrom
francinelucca merged 8 commits intoprimer:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e1e577c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simurai
reviewed
Mar 12, 2026
Contributor
There was a problem hiding this comment.
@kylewaynebenson I added a Changeset 297accf, but CI still fails. I think the following is missing:
- Add a keyword to keywords.json 👉
"lockup-github": ["brand", "github", "logo"], - Add the React icon name (
LockupGithubIcon) to public-api.test.js.snap. There might be a script to use, but maybe also fine to just add it manually.
Updated version for @primer/octicons to minor and modified the change log entries.
simurai
approved these changes
Mar 17, 2026
Contributor
simurai
left a comment
simurai
left a comment
There was a problem hiding this comment.
Ok, I changed the version to minor since we add an additional icon.
Otherwise, I think this is good to ship? 🚢
francinelucca
approved these changes
Mar 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark 24
Mark 16
Before was slightly stretched to pixel fit 16x16, after restores to un-stretched circle
Logo 24
Icon is slightly wider to keep height match with old logotype.
Logo 16