Split JavaScript and Ruby CI workflows by Copilot · Pull Request #1273 · primer/octicons

Copilot · 2026-07-27T18:53:00Z

Separate JavaScript and Ruby CI into independent workflows with dedicated lint and test jobs covering every package.

JavaScript
- Runs lint, build, tests, type checks, and package validation across all npm packages.
- Updates the styled package test tooling so its suite runs under the workspace dependency model.
Ruby
- Runs lint across all gems.
- Builds Octicons assets and tests the base, helper, and Jekyll gems against the generated package.
Security
- Restricts workflow token permissions to read-only repository contents.

changeset-bot · 2026-07-27T18:53:07Z

⚠️ No Changeset found

Latest commit: 20fac0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

joshblack

@copilot bias to lowercase for names (e.g. use lint and don't rename to name: Lint). Update the JavaScript workflow name to just be js. Remove changes unrelated to the workflow updates (this should only change GitHub actions, no longer files)

Copilot · 2026-07-27T19:35:41Z

@copilot bias to lowercase for names (e.g. use lint and don't rename to name: Lint). Update the JavaScript workflow name to just be js. Remove changes unrelated to the workflow updates (this should on...

Addressed in 3c8e857: workflow names are lowercase (js/ruby), redundant capitalized job names are removed, and all non-Actions files are restored.

joshblack · 2026-07-27T20:59:37Z

@copilot fix CI

Copilot · 2026-07-27T21:08:46Z

@copilot fix CI

Fixed in cdbfbf2. The JavaScript workflow now restores the shared build artifact and isolates workspace installs using the previously passing CI structure. All matrix checks pass locally; new Actions runs are awaiting approval.

joshblack

@copilot refactor the js workflows where possible to use the npm cli option for running a command across all workspaces instead of doing the matrix strategy

Copilot · 2026-07-27T21:37:41Z

@copilot refactor the js workflows where possible to use the npm cli option for running a command across all workspaces instead of doing the matrix strategy

Addressed in 3dc3d42. The JavaScript lint and test matrices are replaced with npm workspace commands while preserving the passing test coverage.

joshblack

@copilot don't use the matrix strategy for ruby either, just run lint as one step that covers everything. For js tests, the syntax seems strange to target specific workspaces. Let's just run tests and lint and what not as one step (or tell me why this wouldn't work)

Copilot · 2026-07-28T20:52:21Z

@copilot apply review feedback

Applied in the latest commit:

ruby.yml: Node version now uses node-version-file: '.nvmrc' (picks up 26) instead of hardcoding 20.
Rakefile: Gem selection uses max_by { |f| File.mtime(f) } to pick the most recently built gem, with a clear error if none exist.
lib/octicons_jekyll/Gemfile: Version constraint updated from 19.8.0 to 19.9.0 to match the built gem so Bundler will actually use it.

joshblack · 2026-07-28T20:57:55Z

@copilot fix CI

Copilot · 2026-07-28T21:01:28Z

@copilot fix CI

Fixed in the latest commit. The jekyll-octicons.gemspec still declared octicons 19.8.0 while the Gemfile was updated to 19.9.0 — Bundler couldn't resolve the conflicting constraints. Updated the gemspec to 19.9.0 so both are consistent.

joshblack · 2026-07-29T17:03:57Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-07-29T17:06:05Z

@copilot resolve the merge conflicts in this pull request

Resolved in the merge commit. Conflicts were:

.github/workflows/ci.yml — kept deleted (replaced by the new javascript.yml/ruby.yml workflows)
lib/octicons_jekyll/Gemfile — took main's 19.32.0
lib/octicons_jekyll/jekyll-octicons.gemspec — took main's 19.32.0

joshblack

@copilot update these workflows so they are pinned similar to others in the project now (e.g. they use a sha but have the version as a comment afterwards). make sure they are using the latest versions of actions, too

Copilot · 2026-07-29T18:02:34Z

@copilot update these workflows so they are pinned similar to others in the project now (e.g. they use a sha but have the version as a comment afterwards). make sure they are using the latest versions...

Done in the latest commit. All actions in both workflows are now pinned to the same SHAs used elsewhere in the project, with the version as an inline comment:

actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0

joshblack · 2026-07-29T18:03:34Z

    "build": "script/build.js --input icons/**/*.svg --output lib/build/data.json",
    "changeset:version": "changeset version && script/version lib/octicons_node/package.json",
-    "lint": "eslint tests",
+    "lint": "eslint tests lib/octicons_node/index.js lib/octicons_node/tests lib/octicons_react/pages lib/octicons_react/script lib/octicons_react/src lib/octicons_styled/script lib/octicons_styled/src",


@copilot could we update this so it just checks all js/ts/tsx files?

Done in the latest commit — the lint script now runs eslint '**/*.{js,ts,tsx}'.

joshblack · 2026-07-30T18:00:57Z

@copilot resolve the merge conflicts in this pull request

…ows-separate-ruby-js # Conflicts: # package.json

Copilot · 2026-07-30T18:04:52Z

@copilot resolve the merge conflicts in this pull request

Resolved in the merge commit. Conflicts were:

package.json lint script — took main's eslint . (landed via Lint all JavaScript and TypeScript files #1294)
eslint.config.mjs — took main's expanded TypeScript support (from Lint all JavaScript and TypeScript files #1294)
.github/workflows/ci.yml — kept deleted (replaced by javascript.yml/ruby.yml)

Copilot AI added 3 commits July 27, 2026 18:22

Split JavaScript and Ruby workflows

42eeab1

Limit workflow token permissions

6a37f72

Cover all JavaScript packages in CI

2e10d4a

Copilot AI assigned Copilot and joshblack Jul 27, 2026

Copilot created this pull request from a session on behalf of joshblack July 27, 2026 18:53 View session

Copilot finished work on behalf of joshblack July 27, 2026 18:53

Copilot AI requested a review from joshblack July 27, 2026 18:53

joshblack reviewed Jul 27, 2026

View reviewed changes

Copilot started work on behalf of joshblack July 27, 2026 19:28 View session

Address workflow naming and scope feedback

3c8e857

Copilot finished work on behalf of joshblack July 27, 2026 19:36

Copilot AI requested a review from joshblack July 27, 2026 19:36

joshblack added the skip changeset This change does not need a changelog label Jul 27, 2026

Copilot started work on behalf of joshblack July 27, 2026 21:00 View session

Fix JavaScript CI workspace isolation

cdbfbf2

Copilot finished work on behalf of joshblack July 27, 2026 21:09

joshblack reviewed Jul 27, 2026

View reviewed changes

Copilot started work on behalf of joshblack July 27, 2026 21:32 View session

Refactor JavaScript CI workspace commands

3dc3d42

Copilot finished work on behalf of joshblack July 27, 2026 21:38

Copilot AI requested a review from joshblack July 27, 2026 21:38

joshblack reviewed Jul 28, 2026

View reviewed changes

Copilot started work on behalf of joshblack July 28, 2026 15:16 View session

Simplify JavaScript and Ruby checks

f85aba8

Copilot started work on behalf of joshblack July 28, 2026 20:49 View session

Apply review feedback: Node version, gem selection, Jekyll version pin

2f2da38

Copilot finished work on behalf of joshblack July 28, 2026 20:52

Copilot started work on behalf of joshblack July 28, 2026 20:58 View session

Fix jekyll gemspec octicons version to 19.9.0

68d2a01

Copilot finished work on behalf of joshblack July 28, 2026 21:01

Copilot started work on behalf of joshblack July 29, 2026 17:04 View session

Merge main into branch, resolve conflicts

7025430

Copilot finished work on behalf of joshblack July 29, 2026 17:06

joshblack reviewed Jul 29, 2026

View reviewed changes

Copilot started work on behalf of joshblack July 29, 2026 18:01 View session

Pin workflow actions to SHA with version comments

785418c

Copilot finished work on behalf of joshblack July 29, 2026 18:02

Copilot AI requested a review from joshblack July 29, 2026 18:02

joshblack reviewed Jul 29, 2026

View reviewed changes

Copilot started work on behalf of joshblack July 29, 2026 18:04 View session

chore: update lint script to check all js/ts/tsx files

932852f

Copilot finished work on behalf of joshblack July 29, 2026 18:06

Copilot AI requested a review from joshblack July 29, 2026 18:06

Copilot started work on behalf of joshblack July 30, 2026 18:01 View session

Merge remote-tracking branch 'origin/main' into copilot/update-workfl…

20fac0b

…ows-separate-ruby-js # Conflicts: # package.json

Copilot finished work on behalf of joshblack July 30, 2026 18:05

Uh oh!

Conversation

Copilot AI commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

joshblack left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 27, 2026

Uh oh!

joshblack commented Jul 27, 2026

Uh oh!

Copilot AI commented Jul 27, 2026

Uh oh!

joshblack left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 27, 2026

Uh oh!

joshblack left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 28, 2026

Uh oh!

joshblack commented Jul 28, 2026

Uh oh!

Copilot AI commented Jul 28, 2026

Uh oh!

joshblack commented Jul 29, 2026

Uh oh!

Copilot AI commented Jul 29, 2026

Uh oh!

joshblack left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 29, 2026

Uh oh!

joshblack Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

joshblack commented Jul 30, 2026

Uh oh!

Copilot AI commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 27, 2026 •

edited

Loading

changeset-bot Bot commented Jul 27, 2026 •

edited

Loading