-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Vite #213
base: main
Are you sure you want to change the base?
Migrate to Vite #213
Conversation
Remove hardcoded yarn version
Hi there! 👋 Thanks so much for taking the time to make this PR 🙏 Definitely agreed moving off CRA would be 💯 Just had some questions that came up when looking at this and would love to hear your thoughts 👀
|
@joshblack The goal with using Vite was to stay as close as possible to "pure React", where folks can just write HTML / CSS / import Primer React components. For most designers starting a prototype, what they're looking for is a way to render static layouts in code, with some interactivity sprinkled on top. Next and Tanstack are great for larger, stateful prototypes. @victoriaNine started a prototype with this template and migrated to Next bc she needed client-side routing. I think having a Next/Tanstack variant of this template would also be good, but they aim at different needs / experience levels IMO.
Yeah, it reads the Keep in mind that while Next is "not complicated", the target audience for this template is folks who don't really know how to use React, so the goal is to avoid stacking multiple concepts/frameworks for them to understand. |
@joshblack Let me know if you have any other thoughts in the way of merging this PR 😄 I'd be happy to keep this Vite-based version as a separate template, but staying with CRA makes adoption pretty tough at this point, and Vite seems to be the winning comparable solution at the moment. |
Just found out our React codespaces template also uses Vite: https://github.com/github/codespaces-react |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @dfosco! I think everything looks good! I left one comment which I think should be it 😁
@TylerJDev Thanks for the review! Fixed the merge conflicts, including the upcoming one with the package.json from |
This is a major update to react-template that:
I appreciate if the team feels this PR is too big to merge at once, and I'd be happy to find smaller slices if that's a better way!
This started as a separate (private) repo on https://github.com/github/primer-react-prototype, and I was encouraged to merge it back. Since there are no private forks however, it was messy to pull changes back, so apologies if the git history
looks... weird 😅