Skip to content

feat(ActionList): remove modern actionlist FF #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(ActionList): remove modern actionlist FF #6017

wants to merge 8 commits into from

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented May 7, 2025 •
edited
Loading

Relates to https://github.com/github/primer/issues/4997

Changed

  • Rebuild SelectPanel snapshots

Removed

  • FilteredActionListEntry
  • ModernActionList test cases
  • FilteredActionListWithDeprecatedActionList.tsx
  • ModernActionList usage throughout the codebase

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings May 7, 2025 14:52
@francinelucca francinelucca requested review from a team as code owners May 7, 2025 14:52
Copilot
Copilot AI reviewed May 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 436 out of 436 changed files in this pull request and generated no comments.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 980d849

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label May 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 7, 2025
@francinelucca francinelucca changed the title feat(ActionList); remove modern actionlsit FF feat(ActionList): remove modern actionlsit FF May 7, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6017 May 7, 2025 14:58 Abandoned
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.9 KB (-2.82% 🔽)
packages/react/dist/browser.umd.js 96.11 KB (-2.84% 🔽)

@francinelucca francinelucca requested a review from hectahertz May 7, 2025 15:01
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/376702

@github-actions github-actions bot requested a deployment to storybook-preview-6017 May 7, 2025 15:06 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6017 May 7, 2025 15:21 Inactive
@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 7, 2025
hectahertz
hectahertz approved these changes May 7, 2025
View reviewed changes
@github-actions github-actions bot requested a deployment to storybook-preview-6017 May 7, 2025 17:55 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6017 May 7, 2025 18:14 Inactive
@francinelucca francinelucca changed the title feat(ActionList): remove modern actionlsit FF feat(ActionList): remove modern actionlist FF May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack left review comments

Copilot code review Copilot Copilot left review comments

@jonrohan jonrohan jonrohan approved these changes

@hectahertz hectahertz hectahertz approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francinelucca @jonrohan @joshblack @hectahertz