fix(Table): update TableContainer to place className on outermost element
#6032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6750088 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Table.Container so that any passed className and other HTML attributes are applied to its outermost wrapper component.
- Destructure and forward
classNameand other...restprops toBoxWithFallback - Merge the provided
classNamewith the component’s default container class
Comments suppressed due to low confidence (1)
packages/react/src/DataTable/Table.tsx:238
- Add a unit test for Table.Container to verify that provided
classNameand other HTML attributes (e.g.,id,data-*) are applied to the outermostBoxWithFallbackelement.
<BoxWithFallback {...rest} className={clsx(className, classes.TableContainer)} sx={sxProp}>
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
jonrohan
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/5185
Update the
Table.Containercomponent to correctly place the providedclassNameon the outermost element.Changelog
New
Changed
Table.Containerto place providedclassNameon outermost elementRemoved
Rollout strategy