Skip to content

test(Blankslate): add tests for Blankslate to vitest #6034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshblack
Copy link
Member

Noticed that we didn't have any tests yet for Blankslate so used copilot to generate some for us based on existing tests 👀

Changelog

New

  • Add test file for Blankslate to vitest

Changed

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 20:36
@joshblack joshblack added the skip changeset This change does not need a changelog label May 9, 2025
@joshblack joshblack requested a review from a team as a code owner May 9, 2025 20:36
@joshblack joshblack requested a review from hectahertz May 9, 2025 20:36
Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: a7fac83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label May 9, 2025
Copy link
Contributor

github-actions bot commented May 9, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a Vitest test suite for the Blankslate component and updates test configs to include these new tests.

  • Introduce a new test file for Blankslate
  • Update Vitest and Jest configurations to discover Blankslate tests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/react/vitest.config.mts Include src/Blankslate/**/*.test.* pattern in Vitest
packages/react/src/Blankslate/Blankslate.test.tsx Add Vitest tests for Blankslate component
packages/react/jest.config.js Add <rootDir>/src/Blankslate/ to Jest test paths

Copy link
Contributor

github-actions bot commented May 9, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.57 KB (0%)
packages/react/dist/browser.umd.js 96.83 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants