-
Notifications
You must be signed in to change notification settings - Fork 610
fix(Overlay): reset maxheight and maxwidth values when on fullscreen #6036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7246124 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that the fullscreen variant of the Overlay resets any previously applied max-width and max-height constraints, allowing it to truly occupy the full viewport.
- Added
max-width: 100vw
to override prior width limits in fullscreen mode - Added
max-height: unset
to remove prior height limits in fullscreen mode
size-limit report 📦
|
Co-authored-by: Copilot <[email protected]>
Changelog
New
Rollout strategy
Testing & Reviewing
Merge checklist