Skip to content

fix(Overlay): reset maxheight and maxwidth values when on fullscreen #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented May 9, 2025

Changelog

New

  • Added maxWidth and maxHeight prop to responsive fullscreen variant CSS in overlay to override previous set values

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 21:36
@francinelucca francinelucca requested a review from a team as a code owner May 9, 2025 21:36
@francinelucca francinelucca requested a review from jonrohan May 9, 2025 21:36
Copy link

changeset-bot bot commented May 9, 2025

🦋 Changeset detected

Latest commit: 7246124

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 9, 2025
Copy link
Contributor

github-actions bot commented May 9, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that the fullscreen variant of the Overlay resets any previously applied max-width and max-height constraints, allowing it to truly occupy the full viewport.

  • Added max-width: 100vw to override prior width limits in fullscreen mode
  • Added max-height: unset to remove prior height limits in fullscreen mode

Copy link
Contributor

github-actions bot commented May 9, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96 KB (0%)
packages/react/dist/browser.umd.js 96.2 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6036 May 9, 2025 21:45 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6036 May 9, 2025 21:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants