feat(ActionBar): customizable overflow menu label#7520
feat(ActionBar): customizable overflow menu label#7520harshbhonsle wants to merge 1 commit intoprimer:mainfrom
Conversation
|
TylerJDev
left a comment
There was a problem hiding this comment.
Overall looks great! Just left one request, let me know if you have questions. Thank you for the PR too! ✨
| gap: 'condensed', | ||
| }, | ||
|
|
||
| render: ({'aria-labelledby': _, overflowLabel, ...args}) => ( |
There was a problem hiding this comment.
Could we rely on the spread ({...args} line 32) to pass the overflowLabel to the story? This way we don't need to create the object entirely.
Let me know if that makes sense, or if you have questions!
| render: ({'aria-labelledby': _, overflowLabel, ...args}) => ( | |
| render: ({'aria-labelledby': _, overflowLabel, ...args}) => ( |
|
Also, can we add a changeset of In addition, you might need to run |
Closes: #7437
Changelog
New
overflowLabelprop toActionBarPropswith default"More items".overflowLabelas a control.Changed
aria-labelnow usesoverflowLabelinstead of hardcoded"More {ariaLabel} items".Removed
Rollout strategy
Testing & Reviewing
"More items"."More actions") update correctly.ActionBarundersrc/__tests__. Fix validated through Storybook preview.Merge checklist