Skip to content

test: handle expected console output#7983

Open
joshblack wants to merge 2 commits into
joshblack/fail-on-console/setupfrom
joshblack/fail-on-console/expected-console-errors
Open

test: handle expected console output#7983
joshblack wants to merge 2 commits into
joshblack/fail-on-console/setupfrom
joshblack/fail-on-console/expected-console-errors

Conversation

@joshblack

@joshblack joshblack commented Jun 12, 2026

Copy link
Copy Markdown
Member

Closes: N/A

Updates tests that intentionally trigger React warnings or errors so the expected console output is explicitly mocked. This keeps the original assertions while making those tests compatible with console-failure enforcement.

Changelog

New

  • N/A

Changed

  • Tests now use shared helpers for expected console errors and warnings.

Removed

  • N/A

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; test-only changes.

Testing & Reviewing

Validated as part of the final stack with build, tests, type-check, lint, CSS lint, and format checks.

Merge checklist

@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 24c767b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the staff Author is a staff member label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 12, 2026
@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 12, 2026
@joshblack joshblack changed the title Handle expected console output in tests test: handle expected console output Jun 12, 2026
@github-actions github-actions Bot temporarily deployed to storybook-preview-7983 June 12, 2026 17:04 Inactive
@joshblack joshblack force-pushed the joshblack/fail-on-console/setup branch from f419fb1 to cd99468 Compare June 12, 2026 17:29
@joshblack joshblack force-pushed the joshblack/fail-on-console/expected-console-errors branch from 09ab19c to 78c1fc6 Compare June 12, 2026 17:29
@github-actions github-actions Bot temporarily deployed to storybook-preview-7983 June 12, 2026 17:41 Inactive
@joshblack joshblack force-pushed the joshblack/fail-on-console/setup branch from cd99468 to 0c91659 Compare June 12, 2026 18:31
@joshblack joshblack force-pushed the joshblack/fail-on-console/expected-console-errors branch from 78c1fc6 to 422d492 Compare June 12, 2026 18:31
@github-actions github-actions Bot temporarily deployed to storybook-preview-7983 June 12, 2026 18:43 Inactive
@joshblack joshblack force-pushed the joshblack/fail-on-console/setup branch from 0c91659 to 6aa9229 Compare June 15, 2026 16:24
@joshblack joshblack force-pushed the joshblack/fail-on-console/expected-console-errors branch from 422d492 to e8e6005 Compare June 15, 2026 16:24
@joshblack joshblack marked this pull request as ready for review June 15, 2026 16:25
@joshblack joshblack requested a review from a team as a code owner June 15, 2026 16:25
@joshblack joshblack requested review from Copilot and llastflowers and removed request for Copilot June 15, 2026 16:25
@github-actions github-actions Bot requested a deployment to storybook-preview-7983 June 15, 2026 16:28 Abandoned
@joshblack joshblack force-pushed the joshblack/fail-on-console/setup branch from 6aa9229 to ab1bb8e Compare June 15, 2026 16:37
@joshblack joshblack force-pushed the joshblack/fail-on-console/expected-console-errors branch from e8e6005 to 24c767b Compare June 15, 2026 16:37
@github-actions github-actions Bot temporarily deployed to storybook-preview-7983 June 15, 2026 16:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant