ActionList: Add tooltipDirection prop to ActionList.TrailingAction#7994
ActionList: Add tooltipDirection prop to ActionList.TrailingAction#7994TylerJDev wants to merge 2 commits into
tooltipDirection prop to ActionList.TrailingAction#7994Conversation
🦋 Changeset detectedLatest commit: 1026d40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new tooltipDirection prop on ActionList.TrailingAction so consumers can control the tooltip placement (defaulting to 'w'), and records the API addition via docs and a changeset.
Changes:
- Added
tooltipDirectiontoActionList.TrailingActionprops and forwarded it to the underlyingIconButton. - Updated ActionList docs metadata to document the new prop.
- Added a minor changeset for the new public API surface.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/ActionList/TrailingAction.tsx | Adds tooltipDirection prop (default 'w') and forwards it to IconButton. |
| packages/react/src/ActionList/ActionList.docs.json | Documents the new tooltipDirection prop for ActionList.TrailingAction. |
| .changeset/late-sides-lead.md | Declares a minor release for the new prop addition. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 3
| { | ||
| "name": "tooltipDirection", | ||
| "type": "'n' | 'ne' | 'e' | 'se' | 's' | 'sw' | 'w' | 'nw'", | ||
| "defaultValue": "'n'", |
| icon?: React.ElementType | ||
| label: string | ||
| className?: string | ||
| style?: React.CSSProperties | ||
| } | ||
| } & Pick<IconButtonProps, 'tooltipDirection'> |
| <IconButton | ||
| as={as} | ||
| aria-label={label} | ||
| icon={icon} | ||
| variant="invisible" | ||
| tooltipDirection="w" | ||
| tooltipDirection={tooltipDirection} | ||
| href={href} |
Closes https://github.com/github/primer/issues/6746
Adds a new
tooltipDirectionprop toActionList.TrailingAction, allowing consumers to control the direction of the tooltip shown when hovering over the trailing action.Changelog
New
tooltipDirectionprop toActionList.TrailingAction(defaults to'w'), forwarded to the underlyingIconButton'stooltipDirection.Removed
Rollout strategy
Merge checklist