Update package.json import paths for app files - #4101
Merged
Conversation
🦋 Changeset detectedLatest commit: 6ab1ab6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Update import paths in package.json for application files.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts package.json subpath exports in @primer/view-components to address consumer import resolution issues (notably Sass failing to import the published stylesheet from an app/... path).
Changes:
- Updates the
exportsmapping for./app/*inpackage.json. - Adds a patch changeset for publishing the fix.
Show a summary per file
| File | Description |
|---|---|
| package.json | Modifies the exports mapping intended to affect how app/* paths resolve for consumers (JS/TS tooling and Sass). |
| .changeset/sour-pets-flash.md | Adds a patch changeset entry describing the release note for the import-path fix. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
19
to
22
| "./app/*": { | ||
| "types": "./app/*.d.ts", | ||
| "import": "./app/*.js", | ||
| "default": "./app/*.js" | ||
| "default": "./app/*" | ||
| }, |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry I still don't have this correct #4099 #4096
Sass is failing to import the css file at
@import '@primer/view-components/app/assets/styles/primer_view_components';