feat: adds better tracking of funds going to treasury #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ckartik
commented
Jan 22, 2025
ckartik
commented
- Improves traceability of funds going to treasury
- Improves slashing traceability based on commitment digest.
shaspitz
reviewed
Jan 22, 2025
shaspitz
approved these changes
Jan 23, 2025
| @@ -126,7 +128,7 @@ contract ProviderRegistry is | |||
| bidderSlashedAmount[bidder] += residualAmt; | |||
| } | |||
|
|
|||
| emit FundsSlashed(provider, residualAmt + penaltyFee); | |||
| emit FundsSlashed(provider, residualAmt + penaltyFee, commitmentDigest); | |||
There was a problem hiding this comment.
So I thought what we discussed is emitting the new event and not changing the old one. If we change the old one I am not sure how backward compatibility works. For eg, if they listen to old contract events with the new ABI what would happen? Would it be able to fill only the relevant items?
| @@ -10,7 +10,7 @@ interface IProviderRegistry { | |||
| event FundsDeposited(address indexed provider, uint256 amount); | |||
|
|
|||
| /// @dev Event emitted when funds are slashed | |||
| event FundsSlashed(address indexed provider, uint256 amount); | |||
| event FundsSlashed(address indexed provider, uint256 amount, bytes32 indexed commitmentDigest); | |||
There was a problem hiding this comment.
If we add a new field which is indexed I am not sure if it will be able to Watch/Filter this event if we listen for it for block numbers before the contract update was made. This might be a problem for indexing the chain data using other tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.